Skip to content

rustc_expand: Factor out Annotatable::into_tokens to a separate method - #69680

Merged
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nont4
Mar 7, 2020
Merged

rustc_expand: Factor out Annotatable::into_tokens to a separate method#69680
bors merged 1 commit into
rust-lang:masterfrom
petrochenkov:nont4

Conversation

@petrochenkov

Copy link
Copy Markdown
Contributor

Minor refactoring salvaged from #69594.
r? @Centril

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2020
@Centril

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Mar 3, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 33f8e462fd4c6072f5898a7681449512990bdda8 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2020
@CentrilCentril mentioned this pull request Mar 6, 2020
@bors

bors commented Mar 6, 2020

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (presumably #69586) made this pull request unmergeable. Please resolve the merge conflicts.

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 6, 2020
bors added a commit that referenced this pull request Mar 6, 2020
Rollup of 6 pull requests
Successful merges:
- #69656 (Use .next() instead of .nth(0) on iterators.)
- #69674 (Rename DefKind::Method and TraitItemKind::Method )
- #69676 (Pass correct place to `discriminant_switch_effect`)
- #69706 (Use subslice patterns in slice methods)
- #69714 (Make PlaceRef take just one lifetime)
- #69727 (Avoid using `unwrap()` in suggestions)
Failed merges:
- #69589 (ast: `Mac`/`Macro` -> `MacCall`)
- #69680 (rustc_expand: Factor out `Annotatable::into_tokens` to a separate method)
r? @ghost
@petrochenkov

Copy link
Copy Markdown
ContributorAuthor

@bors r=Centril

@bors

bors commented Mar 6, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 2d0c5b4 has been approved by Centril

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 6, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 7, 2020
rustc_expand: Factor out `Annotatable::into_tokens` to a separate method
Minor refactoring salvaged from rust-lang#69594.
r? @Centril
@CentrilCentril mentioned this pull request Mar 7, 2020
@CentrilCentril mentioned this pull request Mar 7, 2020
bors added a commit that referenced this pull request Mar 7, 2020
Rollup of 9 pull requests
Successful merges:
- #67741 (When encountering an Item in a pat context, point at the item def)
- #68985 (Parse & reject postfix operators after casts)
- #69656 (Use .next() instead of .nth(0) on iterators.)
- #69680 (rustc_expand: Factor out `Annotatable::into_tokens` to a separate method)
- #69690 (test(pattern): add tests for combinations of pattern features)
- #69706 (Use subslice patterns in slice methods)
- #69727 (Avoid using `unwrap()` in suggestions)
- #69754 (Update deprecation version to 1.42 for Error::description)
- #69782 (Don't redundantly repeat field names (clippy::redundant_field_names))
Failed merges:
r? @ghost
@bors
bors merged commit e9c3ddc into rust-lang:masterMar 7, 2020
@petrochenkov
petrochenkov deleted the nont4 branch February 22, 2025 18:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@petrochenkov@Centril@bors@rust-highfive