Uh oh!
There was an error while loading. Please reload this page.
Rollup of 9 pull requests - #70338
Closed
Centril wants to merge 35 commits into
Closed
Conversation
…vel-doc, r=Dylan-DPC Add lint when no doc is present at the crate-level Follow-up of rust-lang#66267. r? @kinnison
Replace some desc logic in librustc_lint with article_and_desc r? @eddyb@Centril@matthewjasper Followup to rust-lang#69674 Blocked on rust-lang#69498
…atthewjasper Make `needs_drop` less pessimistic on generators Generators only have non-trivial drop logic when they may store (in upvars or across yields) a type that does. This prevents generation of some unnecessary MIR in simple generators. There might be some impact on compile times, but this is probably limited in real-world applications. ~~This builds off of rust-lang#69814 since that contains some fixes that are made relevant by *this* PR (see rust-lang#69814 (comment) (this has been merged)
…op-detector, r=RalfJung Remove const eval loop detector Now that there is a configurable instruction limit for CTFE (see rust-lang#67260), we can replace the loop detector with something much simpler. See rust-lang#66946 for more discussion about this. Although the instruction limit is nightly-only, the only practical way to reach the default limit uses nightly-only features as well (although CTFE will still execute code using such features inside an array initializer on stable). This will at the very least require a crater run, since it will result in an error wherever the "long running const eval" warning appeared before. We may need to increase the default for `const_eval_limit` to work around this. Resolvesrust-lang#54384 cc rust-lang#49980 r? @oli-obk cc @RalfJung
…r=estebank Fix invalid suggestion on `&mut` iterators yielding `&` references Fixesrust-lang#69789. rustc suggested an invalid code when `&` reference from `&mut` iterator is mutated. The compiler knew we're mutating a value behind `&` reference, but as the assignment RHS is from desugaring, it could only see the iterator expression from source and inserted `mut` there. r? @estebank
…k,wesleywiser get rid of ConstPropUnsupported; use ZST marker structs instead This gets rid of yet another machine-specific error variant. r? @oli-obk
…r=nikomatsakis Remove `ReClosureBound` We now substitute external names for regions in the query response. r? @nikomatsakis
…r=Centril Account for bad placeholder types in where clauses Fixrust-lang#70291. Follow up to rust-lang#69148.
…an-DPC Clean up E0452 explanation r? @Dylan-DPC
Centril
commented
Mar 23, 2020
ContributorAuthor
@bors r+ p=9 rollup=never |
bors
commented
Mar 23, 2020
Collaborator
📌 Commit 58f4f1e has been approved by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
needs_dropless pessimistic on generators #70015 (Makeneeds_dropless pessimistic on generators)&mutiterators yielding&references #70264 (Fix invalid suggestion on&mutiterators yielding&references)ReClosureBound#70277 (RemoveReClosureBound)Failed merges:
r? @ghost