Remove unused abs_path method from rustc_span::source_map::FileLoader by shlevy · Pull Request #71263 · rust-lang/rust

shlevy · 2020-04-17T21:52:07Z

No description provided.

rust-highfive · 2020-04-17T21:52:10Z

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

shlevy · 2020-04-17T21:53:02Z

I noticed this was unused, but I'm not sure if we want to keep it around for compatibility or not.

Xanewok · 2020-04-17T22:10:23Z

FWIW it's used by the RLS but the function is so trivial I'd be fine with removing this (in fact it is even reimplemented in the ipc bridge for of the RLS).

shlevy · 2020-04-17T22:34:10Z

@Xanewok Looks like it's only used to implement the method itself in a wrapper? 🙂

Xanewok · 2020-04-17T22:37:40Z

Well, you're right - rustc won't use it anyway so we might just get rid of it entirely. Thanks 👍

r? @Xanewok
@bors r+ rollup

bors · 2020-04-17T22:37:41Z

📌 Commit c7899a0 has been approved by Xanewok

…r=Xanewok Remove unused abs_path method from rustc_span::source_map::FileLoader

Dylan-DPC-zz · 2020-04-18T20:10:59Z

probably breaking rls in the rollup

@bors r-

Xanewok · 2020-04-18T20:12:02Z

Is this no-breakage week for tools already?

Dylan-DPC-zz · 2020-04-18T20:12:32Z

Yep

shlevy · 2020-04-18T21:05:39Z

Sorry, does this mean we can't do this removal at all, or just that we have to wait a week?

If we can't remove it, can we mark it deprecated/unused?

Dylan-DPC-zz · 2020-04-18T21:08:26Z

@shlevy just have to wait a week :)

shlevy · 2020-04-26T20:23:31Z

@Xanewok @Dylan-DPC Good to move forward?

Xanewok · 2020-04-26T20:29:46Z

I believe so, thanks

@bors r+

bors · 2020-04-26T20:29:47Z

📌 Commit c7899a0 has been approved by Xanewok

@ghost

Rollup of 6 pull requests Successful merges: - rust-lang#68716 (Stabilize `Span::mixed_site`) - rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader) - rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`) - rust-lang#71419 (add message for resolution failure because wrong namespace) - rust-lang#71438 (Tweak some suggestions in `rustc_resolve`) - rust-lang#71589 (remove Unique::from for shared pointer types) Failed merges: r? @ghost

Breakage caused by rust-lang#71263.

@ghost

Update RLS to unbreak toolstate Breakage caused by rust-lang#71263. r? @ghost

rust-highfive assigned nikomatsakis Apr 17, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 17, 2020

Remove unused abs_path method from rustc_span::source_map::FileLoader
c7899a0

shlevy force-pushed the FileLoader-remove-abs_path branch from 2b8faca to c7899a0Compare April 17, 2020 21:58

rust-highfive assigned Xanewok and unassigned nikomatsakis Apr 17, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 17, 2020

Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 18, 2020
Rollup merge ofrust-lang#71263- shlevy:FileLoader-remove-abs_path, …
6c81475
…r=Xanewok Remove unused abs_path method from rustc_span::source_map::FileLoader

Dylan-DPC-zz mentioned this pull request Apr 18, 2020
Rollup of 5 pull requests #71295
Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2020

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020

Dylan-DPC-zz mentioned this pull request Apr 27, 2020
Rollup of 6 pull requests #71600
Merged

bors merged commit 89aff5f into rust-lang:masterApr 27, 2020

Xanewok added a commit to Xanewok/rust that referenced this pull request Apr 27, 2020
Update RLS to unbreak toolstate
f4ac42f
Breakage caused by rust-lang#71263.

Xanewok mentioned this pull request Apr 27, 2020
Update RLS to unbreak toolstate #71606
Merged

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 28, 2020
Auto merge ofrust-lang#71606- Xanewok:update-rls, r=Xanewok
6db2094
Update RLS to unbreak toolstate Breakage caused by rust-lang#71263. r? @ghost

Uh oh!

Uh oh!

Conversation

shlevy commented Apr 17, 2020

Uh oh!

rust-highfive commented Apr 17, 2020

Uh oh!

shlevy commented Apr 17, 2020

Uh oh!

Xanewok commented Apr 17, 2020

Uh oh!

shlevy commented Apr 17, 2020

Uh oh!

Xanewok commented Apr 17, 2020

Uh oh!

bors commented Apr 17, 2020

Uh oh!

Dylan-DPC-zz commented Apr 18, 2020

Uh oh!

Xanewok commented Apr 18, 2020

Uh oh!

Dylan-DPC-zz commented Apr 18, 2020

Uh oh!

shlevy commented Apr 18, 2020

Uh oh!

Dylan-DPC-zz commented Apr 18, 2020

Uh oh!

shlevy commented Apr 26, 2020

Uh oh!

Xanewok commented Apr 26, 2020

Uh oh!

bors commented Apr 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants