Skip to content

add message for resolution failure because wrong namespace - #71419

Merged
bors merged 2 commits into
rust-lang:masterfrom
contrun:wrong-namespace-rustc-resolve
Apr 27, 2020
Merged

add message for resolution failure because wrong namespace#71419
bors merged 2 commits into
rust-lang:masterfrom
contrun:wrong-namespace-rustc-resolve

Conversation

@contrun

@contruncontrun commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

closes#71406

@rust-highfive

rust-highfive commented Apr 22, 2020

Copy link
Copy Markdown
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
@contruncontrun mentioned this pull request Apr 22, 2020
Closed
@contrun
contrunforce-pushed the wrong-namespace-rustc-resolve branch from 7e9fcc9 to bb1eedbCompareApril 22, 2020 08:05
@petrochenkovpetrochenkov self-assigned this Apr 22, 2020
@estebank

estebank commented Apr 23, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

estebank
estebank reviewed Apr 23, 2020
View reviewed changes
Comment threadsrc/librustc_resolve/lib.rs Outdated
@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2020
@petrochenkov

petrochenkov commented Apr 26, 2020

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Apr 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit eb8a703 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request Apr 27, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2020
@bors
Auto merge ofrust-lang#71600- Dylan-DPC:rollup-7tvzi9n, r=Dylan-DPC
ef71df1
Rollup of 6 pull requests
Successful merges:
- rust-lang#68716 (Stabilize `Span::mixed_site`)
- rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader)
- rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`)
- rust-lang#71419 (add message for resolution failure because wrong namespace)
- rust-lang#71438 (Tweak some suggestions in `rustc_resolve`)
- rust-lang#71589 (remove Unique::from for shared pointer types)
Failed merges:
r? @ghost
@bors
bors merged commit 94ac0ac into rust-lang:masterApr 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@estebankestebankestebank left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Misleading error message when ambiguity between a function and module is introduced

5 participants

@contrun@rust-highfive@estebank@petrochenkov@bors