Skip to content

Point at the return type on .into() failure caused by ? - #71409

Merged
bors merged 1 commit into
rust-lang:masterfrom
estebank:point-at-ret-question-mark-op
Apr 27, 2020
Merged

Point at the return type on .into() failure caused by ?#71409
bors merged 1 commit into
rust-lang:masterfrom
estebank:point-at-ret-question-mark-op

Conversation

@estebank

Copy link
Copy Markdown
Contributor

Fix#35946.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 22, 2020
Comment threadsrc/librustc_trait_selection/traits/error_reporting/suggestions.rs Outdated
@petrochenkov

Copy link
Copy Markdown
Contributor

r=me with nits addressed.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 24, 2020
@estebank
estebankforce-pushed the point-at-ret-question-mark-op branch from 711676f to be90f90CompareApril 26, 2020 18:51
@estebank

Copy link
Copy Markdown
ContributorAuthor

@bors r=petrochenkov

@bors

bors commented Apr 26, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit be90f90 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 26, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 27, 2020
Rollup of 6 pull requests
Successful merges:
- rust-lang#68716 (Stabilize `Span::mixed_site`)
- rust-lang#71263 (Remove unused abs_path method from rustc_span::source_map::FileLoader)
- rust-lang#71409 (Point at the return type on `.into()` failure caused by `?`)
- rust-lang#71419 (add message for resolution failure because wrong namespace)
- rust-lang#71438 (Tweak some suggestions in `rustc_resolve`)
- rust-lang#71589 (remove Unique::from for shared pointer types)
Failed merges:
r? @ghost
@bors
bors merged commit c95bcbc into rust-lang:masterApr 27, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve ? error messages per RFC 1859

4 participants

@estebank@rust-highfive@petrochenkov@bors