Skip to content

add long error explanation for E0228 - #72127

Merged
bors merged 1 commit into
rust-lang:masterfrom
imogenkinsman:long-error-explanation-E0228
May 14, 2020
Merged

add long error explanation for E0228#72127
bors merged 1 commit into
rust-lang:masterfrom
imogenkinsman:long-error-explanation-E0228

Conversation

@imogenkinsman

@imogenkinsmanimogenkinsman commented May 12, 2020

Copy link
Copy Markdown
Contributor

Add long explanation for the E0228 error code
Part of #61137

Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.

@rust-highfive

rust-highfive commented May 12, 2020

Copy link
Copy Markdown
Contributor

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive

rust-highfive commented May 12, 2020

Copy link
Copy Markdown
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2020
@rust-highfive

This comment has been minimized.

Sign in to view
@petrochenkov

petrochenkov commented May 12, 2020

Copy link
Copy Markdown
Contributor

Reference test outputs need to be updated.
This can be done automatically by running ./x.py test --bless --stage 1 --pass check src/test/ui.

@petrochenkovpetrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 12, 2020
@imogenkinsman

imogenkinsman commented May 12, 2020

Copy link
Copy Markdown
ContributorAuthor

I updated the tests - will have a fix shortly for remaining failures.

@petrochenkov

petrochenkov commented May 12, 2020

Copy link
Copy Markdown
Contributor

LGTM.
Could you squash the commits into one?

@imogenkinsman
imogenkinsmanforce-pushed the long-error-explanation-E0228 branch from a5495e8 to 5320bd9CompareMay 13, 2020 00:09
@imogenkinsman

imogenkinsman commented May 13, 2020

Copy link
Copy Markdown
ContributorAuthor

done :)

@petrochenkov

petrochenkov commented May 13, 2020

Copy link
Copy Markdown
Contributor

Thanks!
@bors r+

@bors

bors commented May 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 5320bd9 has been approved by petrochenkov

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 13, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 13, 2020
@Dylan-DPC
Rollup merge ofrust-lang#72127- jademcgough:long-error-explanation-…
68cd0d2
…E0228, r=petrochenkov
add long error explanation for E0228
Add long explanation for the E0228 error code
Part of rust-lang#61137
Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request May 13, 2020
Closed
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 13, 2020
@Dylan-DPC
Rollup merge ofrust-lang#72127- jademcgough:long-error-explanation-…
c8cae1a
…E0228, r=petrochenkov
add long error explanation for E0228
Add long explanation for the E0228 error code
Part of rust-lang#61137
Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request May 13, 2020
Closed
@Dylan-DPC-zzDylan-DPC-zz mentioned this pull request May 14, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2020
@bors
Auto merge ofrust-lang#72202- Dylan-DPC:rollup-6lbxh1s, r=Dylan-DPC
a74d186
Rollup of 8 pull requests
Successful merges:
- rust-lang#71910 (Fix unused_parens false positive when using binary operations)
- rust-lang#72087 (Fix hang in lexical_region_resolve)
- rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.)
- rust-lang#72127 (add long error explanation for E0228)
- rust-lang#72141 (Warn against thread::sleep in async fn)
- rust-lang#72170 (use `require_lang_item` over `unwrap`.)
- rust-lang#72191 (Clean up E0589 explanation)
- rust-lang#72194 (Don't ICE on missing `Unsize` impl)
Failed merges:
r? @ghost
@bors
bors merged commit 746b8ca into rust-lang:masterMay 14, 2020
@imogenkinsman
imogenkinsman deleted the long-error-explanation-E0228 branch May 14, 2020 23:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@petrochenkovpetrochenkov

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@imogenkinsman@rust-highfive@petrochenkov@bors