Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #72202
Merged
Merged
Conversation
Co-authored-by: Bastian Kauschke <bastian_kauschke@hotmail.de>
Because there is at most one file.
Fix unused_parens false positive when using binary operations Fixesrust-lang#71290 r? @cuviper who provided instructions
…matsakis Fix hang in lexical_region_resolve Regionck was stuck in a loop where a region value was changing between two equal regions. Closesrust-lang#72051
…d_files, r=alexcrichton Change `WorkProduct::saved_files` to an `Option`. Because there is at most one file. r? @bjorn3
…E0228, r=petrochenkov add long error explanation for E0228 Add long explanation for the E0228 error code Part of rust-lang#61137 Let me know if this is wrong at all (or can be written more clearly), I'm still learning Rust.
Warn against thread::sleep in async fn I've seen `thread::sleep` wrecking havoc in async servers. There's already an [issue for clippy](rust-lang/rust-clippy#4377), but the std docs could warn against it too.
use `require_lang_item` over `unwrap`. Does not yet replace all uses of `lang_items\(\)\.*\.unwrap\(\)`, as there are more than I expected 😅 Fixesrust-lang#72099 r? @RalfJung *edit: The goal of this this PR is to change ICE from missing lang items to a fatal error.*
…an-DPC Clean up E0589 explanation r? @Dylan-DPC
…tebank
Don't ICE on missing `Unsize` impl
Previously code of the form
```rust
#![feature(unsize, dispatch_from_dyn)]
use std::marker::Unsize;
use std::ops::DispatchFromDyn;
pub struct Foo<'a, T: ?Sized> {
_inner: &'a &'a T,
}
impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
```
would generate an ICE due to the missing `Unsize` impl being run through the `suggest_change_mut` suggestion. This PR adds an early exit and a pointer to the appropriate docs regarding `Unsize` instead:
```
error[E0277]: the trait bound `&'a T: std::marker::Unsize<&'a U>` is not satisfied
--> src/test/ui/issues/issue-71036.rs:11:1
|
11 | impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<&'a U>` is not implemented for `&'a T`
|
= note: all implementations of `Unsize` are provided automatically by the compiler, see <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> for more information
= note: required because of the requirements on the impl of `std::ops::DispatchFromDyn<&'a &'a U>` for `&'a &'a T`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0277`.
```
r? @estebankResolvesrust-lang#71036Dylan-DPC-zz
commented
May 14, 2020
Author
@bors r+ rollup=never p=8 |
bors
commented
May 14, 2020
Collaborator
📌 Commit 7b5bc61 has been approved by |
bors
commented
May 14, 2020
Collaborator
⌛ Testing commit 7b5bc61 with merge cccfcaad3829e903bd404f529683c68e5523a881... |
RalfJung
commented
May 14, 2020
Member
@rustbot modify labels: +rollup |
bors
commented
May 14, 2020
Collaborator
💔 Test failed - checks-actions |
RalfJung
commented
May 14, 2020
Member
bors
commented
May 14, 2020
Collaborator
⌛ Testing commit 7b5bc61 with merge 2a1af5de149d98ca069b79d6551b385fff6eb7e5... |
bors
commented
May 14, 2020
Collaborator
💔 Test failed - checks-actions |
Dylan-DPC-zz
commented
May 14, 2020
Author
@bors retry |
bors
commented
May 14, 2020
Collaborator
bors
commented
May 14, 2020
Collaborator
☀️ Test successful - checks-azure |
This was referenced May 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
WorkProduct::saved_filesto anOption. #72126 (ChangeWorkProduct::saved_filesto anOption.)require_lang_itemoverunwrap. #72170 (userequire_lang_itemoverunwrap.)Unsizeimpl #72194 (Don't ICE on missingUnsizeimpl)Failed merges:
r? @ghost