Uh oh!
There was an error while loading. Please reload this page.
Don't ICE on missing Unsize impl - #72194
Merged
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
estebank
approved these changes
May 14, 2020
estebank
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me after niko's requests!
| let is_from = format!("{}", trait_ref.print_only_trait_path()) | ||
| .starts_with("std::convert::From<"); | ||
| let is_unsize = | ||
| { Some(trait_ref.def_id()) == self.tcx.lang_items().unsize_trait() }; |
Contributor
There was a problem hiding this comment.
Are the braces needed? Have you ran x.py fmt?
ContributorAuthor
There was a problem hiding this comment.
Not strictly necessary, but I ran ./x.py fmt
ContributorAuthor
There was a problem hiding this comment.
I can remove if you think that's better?
Contributor
There was a problem hiding this comment.
Na, if it's fine with fmt it's fine with me.
estebank
commented
May 14, 2020
Contributor
@bors r+ rollup |
bors
commented
May 14, 2020
Collaborator
📌 Commit f6aa161 has been approved by |
RalfJung added a commit
to RalfJung/rust
that referenced
this pull request
May 14, 2020
…tebank
Don't ICE on missing `Unsize` impl
Previously code of the form
```rust
#![feature(unsize, dispatch_from_dyn)]
use std::marker::Unsize;
use std::ops::DispatchFromDyn;
pub struct Foo<'a, T: ?Sized> {
_inner: &'a &'a T,
}
impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
```
would generate an ICE due to the missing `Unsize` impl being run through the `suggest_change_mut` suggestion. This PR adds an early exit and a pointer to the appropriate docs regarding `Unsize` instead:
```
error[E0277]: the trait bound `&'a T: std::marker::Unsize<&'a U>` is not satisfied
--> src/test/ui/issues/issue-71036.rs:11:1
|
11 | impl<'a, T: ?Sized + Unsize<U>, U: ?Sized> DispatchFromDyn<Foo<'a, U>> for Foo<'a, T> {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `std::marker::Unsize<&'a U>` is not implemented for `&'a T`
|
= note: all implementations of `Unsize` are provided automatically by the compiler, see <https://doc.rust-lang.org/stable/std/marker/trait.Unsize.html> for more information
= note: required because of the requirements on the impl of `std::ops::DispatchFromDyn<&'a &'a U>` for `&'a &'a T`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0277`.
```
r? @estebankResolvesrust-lang#71036bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 14, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#71910 (Fix unused_parens false positive when using binary operations) - rust-lang#72087 (Fix hang in lexical_region_resolve) - rust-lang#72126 (Change `WorkProduct::saved_files` to an `Option`.) - rust-lang#72127 (add long error explanation for E0228) - rust-lang#72141 (Warn against thread::sleep in async fn) - rust-lang#72170 (use `require_lang_item` over `unwrap`.) - rust-lang#72191 (Clean up E0589 explanation) - rust-lang#72194 (Don't ICE on missing `Unsize` impl) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously code of the form
would generate an ICE due to the missing
Unsizeimpl being run through thesuggest_change_mutsuggestion. This PR adds an early exit and a pointer to the appropriate docs regardingUnsizeinstead:r? @estebank
Resolves#71036