Uh oh!
There was an error while loading. Please reload this page.
Fix #[thread_local] statics as asm! sym operands - #73033
Merged
Merged
Conversation
oli-obk
reviewed
Jun 6, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
reviewed
Jun 6, 2020
Uh oh!
There was an error while loading. Please reload this page.
oli-obk
commented
Jun 8, 2020
Contributor
@bors r+ |
bors
commented
Jun 8, 2020
Collaborator
📌 Commit 74befd9 has been approved by |
Dylan-DPC-zz pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Jun 11, 2020
Fix #[thread_local] statics as asm! sym operands The `asm!` RFC specifies that `#[thread_local]` statics may be used as `sym` operands for inline assembly. This also fixes a regression in the handling of `#[thread_local]` during monomorphization which caused link-time errors with multiple codegen units, most likely introduced by rust-lang#71192. r? @oli-obk
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#73033 (Fix #[thread_local] statics as asm! sym operands) - rust-lang#73036 (std: Enable atomic.fence emission on wasm32) - rust-lang#73163 (Add long error explanation for E0724) - rust-lang#73187 (Remove missed `cfg(bootstrap)`) - rust-lang#73195 (Provide suggestion to convert numeric op LHS rather than unwrapping RHS) - rust-lang#73247 (Add various Zulip notifications for prioritization) - rust-lang#73254 (Add comment about LocalDefId -> DefId) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
asm!RFC specifies that#[thread_local]statics may be used assymoperands for inline assembly.This also fixes a regression in the handling of
#[thread_local]during monomorphization which caused link-time errors with multiple codegen units, most likely introduced by #71192.r? @oli-obk