Uh oh!
There was an error while loading. Please reload this page.
Add long error explanation for E0724 - #73163
Merged
bors merged 1 commit intoJun 12, 2020
Merged
Conversation
rust-highfive
commented
Jun 9, 2020
Contributor
Some changes occurred in diagnostic error codes |
rust-highfive
commented
Jun 9, 2020
Contributor
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
ayushmishra2005
commented
Jun 11, 2020
ContributorAuthor
r? @davidtwco |
davidtwco
requested changes
Jun 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
ayushmishra2005force-pushed
the
61137-add-long-error-code-e0724
branch
from
June 11, 2020 16:48
6880338 to
0962af8Comparedavidtwco
requested changes
Jun 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
ayushmishra2005force-pushed
the
61137-add-long-error-code-e0724
branch
from
June 11, 2020 17:19
0962af8 to
e1f5248Comparedavidtwco
requested changes
Jun 11, 2020
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
davidtwco
approved these changes
Jun 11, 2020
davidtwco
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks for resolving the comments - could you squash the GitHub suggestion commits. After that, r=me when CI passes.
Minor refactoring Minor refactoring Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Update src/librustc_error_codes/error_codes/E0724.md Co-authored-by: David Wood <Q0KPU0H1YOEPHRY1R2SN5B5RL@david.davidtw.co> Minor refactoring
ayushmishra2005force-pushed
the
61137-add-long-error-code-e0724
branch
from
June 11, 2020 17:48
aea0168 to
68b4c03Comparedavidtwco
commented
Jun 11, 2020
Member
@bors r+ |
bors
commented
Jun 11, 2020
Collaborator
📌 Commit 68b4c03 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 11, 2020
Rollup of 7 pull requests Successful merges: - rust-lang#73033 (Fix #[thread_local] statics as asm! sym operands) - rust-lang#73036 (std: Enable atomic.fence emission on wasm32) - rust-lang#73163 (Add long error explanation for E0724) - rust-lang#73187 (Remove missed `cfg(bootstrap)`) - rust-lang#73195 (Provide suggestion to convert numeric op LHS rather than unwrapping RHS) - rust-lang#73247 (Add various Zulip notifications for prioritization) - rust-lang#73254 (Add comment about LocalDefId -> DefId) Failed merges: r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add long explanation for the E0724 error code
Part of #61137