Skip to content

Add comment about LocalDefId -> DefId - #73254

Merged
bors merged 1 commit into
rust-lang:masterfrom
jyn514:local-def-id-comment
Jun 12, 2020
Merged

Add comment about LocalDefId -> DefId#73254
bors merged 1 commit into
rust-lang:masterfrom
jyn514:local-def-id-comment

Conversation

@jyn514

Copy link
Copy Markdown
Member

Now there are instructions on how to convert back and forth on both
structs, not just one.

See also #73076

r? @lcnr

Now there are instructions on how to convert back and forth on both
structs, not just one.
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 11, 2020
@lcnr

lcnr commented Jun 11, 2020

Copy link
Copy Markdown
Contributor

I don't remember ever getting r+ privileges.

But let's try it anyways
@bors r+

@bors

bors commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

@lcnr: 🔑 Insufficient privileges: Not in reviewers

@jyn514

Copy link
Copy Markdown
MemberAuthor

r? @ecstatic-morse

@Dylan-DPC-zz

Copy link
Copy Markdown

@bors r=lcnr rollup

@bors

bors commented Jun 11, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 1d8da94 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 11, 2020
Rollup of 7 pull requests
Successful merges:
- rust-lang#73033 (Fix #[thread_local] statics as asm! sym operands)
- rust-lang#73036 (std: Enable atomic.fence emission on wasm32)
- rust-lang#73163 (Add long error explanation for E0724)
- rust-lang#73187 (Remove missed `cfg(bootstrap)`)
- rust-lang#73195 (Provide suggestion to convert numeric op LHS rather than unwrapping RHS)
- rust-lang#73247 (Add various Zulip notifications for prioritization)
- rust-lang#73254 (Add comment about LocalDefId -> DefId)
Failed merges:
r? @ghost
@bors
bors merged commit 85a48d0 into rust-lang:masterJun 12, 2020
@jyn514
jyn514 deleted the local-def-id-comment branch June 12, 2020 01:32
@cuvipercuviper added this to the 1.46 milestone May 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants

@jyn514@lcnr@bors@Dylan-DPC-zz@cuviper@rust-highfive@ecstatic-morse