Skip to content

Add a note about the panic behavior of math operations on time objects - #76388

Merged
bors merged 1 commit into
rust-lang:masterfrom
poliorcetics:system-time-document-panic
Oct 6, 2020
Merged

Add a note about the panic behavior of math operations on time objects#76388
bors merged 1 commit into
rust-lang:masterfrom
poliorcetics:system-time-document-panic

Conversation

@poliorcetics

Copy link
Copy Markdown
Contributor

Fixes#71226.

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 5, 2020
@poliorcetics

Copy link
Copy Markdown
ContributorAuthor

@rustbot modify labels: C-enhancement T-doc T-libs

@rustbotrustbot added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs-api [DEPRECATED; DO NOT USE] labels Sep 5, 2020
@Dylan-DPC-zz

Copy link
Copy Markdown

r? @KodrAus

@KodrAus

Copy link
Copy Markdown
Contributor

This looks good to me!

@bors r+ rollup

@bors

bors commented Oct 5, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 492826a has been approved by KodrAus

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 5, 2020
@JohnTitorJohnTitor mentioned this pull request Oct 6, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2020
Rollup of 13 pull requests
Successful merges:
- rust-lang#76388 (Add a note about the panic behavior of math operations on time objects)
- rust-lang#76855 (Revamp rustdoc docs about documentation using `cfg`)
- rust-lang#76995 (Reduce boilerplate with the matches! macro)
- rust-lang#77228 (Add missing examples for MaybeUninit)
- rust-lang#77528 (Avoid unchecked casts in net parser)
- rust-lang#77534 (Disallow overriding forbid in same scope)
- rust-lang#77555 (Allow anyone to set regression labels)
- rust-lang#77558 (Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml})
- rust-lang#77559 (Fix rustdoc warnings about invalid Rust syntax)
- rust-lang#77560 (Fix LitKind's byte buffer to use refcounted slice)
- rust-lang#77573 (Hint doc use convert::identity relative link)
- rust-lang#77587 (Fix span for unicode escape suggestion.)
- rust-lang#77591 (Record `expansion_that_defined` into crate metadata)
Failed merges:
r? `@ghost`
@bors
bors merged commit 59476e9 into rust-lang:masterOct 6, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 6, 2020
@poliorcetics
poliorcetics deleted the system-time-document-panic branch October 6, 2020 19:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsC-enhancementCategory: An issue proposing an enhancement or a PR with one.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libs-api[DEPRECATED; DO NOT USE]

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RustDocs for SystemTime and Instant should note that their Add<Duration> implementations panic

7 participants

@poliorcetics@rust-highfive@Dylan-DPC-zz@KodrAus@bors@sfackler@rustbot