Uh oh!
There was an error while loading. Please reload this page.
Rollup of 13 pull requests - #77606
Merged
Merged
Conversation
Replaces simple bool `match`es of the form
match $expr {
$pattern => true
_ => false
}
and their inverse with invocations of the matches! macro.…ant in the language. (Note that the fact this test existed is a slight sign that we may need a crater run on this bugfix...)
That is, this changes `#[forbid(foo)] #[allow(foo)]` from allowing foo to forbidding foo.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
Fixesrust-lang#77523 Now that hygiene serialization is implemented, we also need to record `expansion_that_defined` so that we properly handle a foreign `SyntaxContext`.
- Move `cfg(doc)` out of `unstable-features`. It's not unstable. - Remove outdated reference to `everybody_loops`. - Improve wording in various places - Give an example of code this allows (and does not allow) - Link to `cfg(doc)` in `doc(cfg)` documentation. Since one is stable and the other is not, don't combine them. - Cleanup wording for `doc(cfg)` - Incorporate changes from rust-lang#76849 - Mention that `doc(cfg)` is also for features
…anic, r=KodrAus Add a note about the panic behavior of math operations on time objects Fixesrust-lang#71226.
Revamp rustdoc docs about documentation using `cfg` - Move `cfg(doc)` out of `unstable-features`. It's not unstable. - Remove outdated reference to `everybody_loops`. - Improve wording in various places - Give an example of code this allows (and does not allow) - Link to `cfg(doc)` in `doc(cfg)` documentation. Since one is stable and the other is not, don't combine them. - Cleanup wording for `doc(cfg)` - Incorporate changes from rust-lang#76849 - Mention that `doc(cfg)` is also for features Addresses rust-lang#76849 (comment). Obsoletes rust-lang#76849 (I made sure to fix the weird dashes too). r? @steveklabnik
Reduce boilerplate with the matches! macro
Replaces simple bool `match`es of the form
match $expr {
$pattern => true
_ => false
}
and their inverse with invocations of the matches! macro.
Limited to rustc_middle for now to get my feet wet.…, r=pickfire Add missing examples for MaybeUninit r? @Dylan-DPC
…lnay Avoid unchecked casts in net parser Once this and rust-lang#77426 are in, I'll send another PR adding scope id parsing. r? @dtolnay
…w-override-forbid-in-same-scope, r=petrochenkov Disallow overriding forbid in same scope Rebased rust-lang#73379. Fixesrust-lang#70819.
…yn514
Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml}
This allows these files to have okay syntax highlighting in editors, and helps avoid nagging from editors which want to suggest that I install a plugin for `*.library` files to view the `config.toml.library` or whatever.
It's a very minor change.
r?@jyn514…d-rust-syntax, r=lcnr Fix rustdoc warnings about invalid Rust syntax
Fix LitKind's byte buffer to use refcounted slice While working on adding a new lint for clippy (see rust-lang/rust-clippy#6044) for avoiding shared ownership of "mutable buffer" types (such as using `Rc<Vec<T>>` instead of `Rc<[T]>`), I noticed a type exported from rustc_ast and used by clippy gets caught by the lint. This PR fixes the exported type. This PR includes the actual change to clippy too, but I will open a PR directly against clippy for that part (although it will currently fail to build there).
Hint doc use convert::identity relative link r? @jyn514
…ic-morse
Fix span for unicode escape suggestion.
If a unicode escape is missing the curly braces, the suggested fix is to add the curly braces, but the span for the fix was incorrect. It was not covering the `\u`, but the suggested text includes the `\u`, causing the resulting fix to be `"\u\u{1234}"`. This changes it so that the span includes the `\u`. An alternate fix would be to remove `\u` from the suggested fix, but I think the error message reads better if the entire escape is included.…estebank Record `expansion_that_defined` into crate metadata Fixesrust-lang#77523 Now that hygiene serialization is implemented, we also need to record `expansion_that_defined` so that we properly handle a foreign `SyntaxContext`.
JohnTitor
commented
Oct 6, 2020
MemberAuthor
bors
commented
Oct 6, 2020
Collaborator
📌 Commit 552933b has been approved by |
bors
commented
Oct 6, 2020
Collaborator
bors
commented
Oct 6, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Oct 6, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
cfg#76855 (Revamp rustdoc docs about documentation usingcfg)expansion_that_definedinto crate metadata #77591 (Recordexpansion_that_definedinto crate metadata)Failed merges:
r? @ghost