Skip to content

Avoid unchecked casts in net parser - #77528

Merged
bors merged 2 commits into
rust-lang:masterfrom
tamird:avoid-cast-net-parser
Oct 6, 2020
Merged

Avoid unchecked casts in net parser#77528
bors merged 2 commits into
rust-lang:masterfrom
tamird:avoid-cast-net-parser

Conversation

@tamird

Copy link
Copy Markdown
Contributor

Once this and #77426 are in, I'll send another PR adding scope id parsing.

r? @dtolnay

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 4, 2020
@tamird
tamirdforce-pushed the avoid-cast-net-parser branch from 2da9068 to f36a7abCompareOctober 4, 2020 14:13
Comment threadlibrary/std/src/net/parser.rs Outdated
@tamird
tamirdforce-pushed the avoid-cast-net-parser branch from f36a7ab to 9601724CompareOctober 4, 2020 16:58

@dtolnaydtolnay left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is terrific.

@dtolnay

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f78a7ad has been approved by dtolnay

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 4, 2020
@JohnTitorJohnTitor mentioned this pull request Oct 6, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 6, 2020
Rollup of 13 pull requests
Successful merges:
- rust-lang#76388 (Add a note about the panic behavior of math operations on time objects)
- rust-lang#76855 (Revamp rustdoc docs about documentation using `cfg`)
- rust-lang#76995 (Reduce boilerplate with the matches! macro)
- rust-lang#77228 (Add missing examples for MaybeUninit)
- rust-lang#77528 (Avoid unchecked casts in net parser)
- rust-lang#77534 (Disallow overriding forbid in same scope)
- rust-lang#77555 (Allow anyone to set regression labels)
- rust-lang#77558 (Rename bootstrap/defaults/{config.toml.PROFILE => config.PROFILE.toml})
- rust-lang#77559 (Fix rustdoc warnings about invalid Rust syntax)
- rust-lang#77560 (Fix LitKind's byte buffer to use refcounted slice)
- rust-lang#77573 (Hint doc use convert::identity relative link)
- rust-lang#77587 (Fix span for unicode escape suggestion.)
- rust-lang#77591 (Record `expansion_that_defined` into crate metadata)
Failed merges:
r? `@ghost`
@bors
bors merged commit eac25fe into rust-lang:masterOct 6, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 6, 2020
@tamird
tamird deleted the avoid-cast-net-parser branch November 17, 2023 15:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@tamird@dtolnay@bors@pickfire@rust-highfive@rustbot