Skip to content

Add docs for BasicBlock - #76732

Merged
bors merged 5 commits into
rust-lang:masterfrom
camelid:mir-basic-block-docs
Sep 20, 2020
Merged

Add docs for BasicBlock#76732
bors merged 5 commits into
rust-lang:masterfrom
camelid:mir-basic-block-docs

Conversation

@camelid

@camelidcamelid commented Sep 15, 2020

Copy link
Copy Markdown
Member

Fixes#76715.

@rustbot modify labels: A-mir T-doc C-enhancement

@rustbotrustbot added A-MIR Area: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.html C-enhancement Category: An issue proposing an enhancement or a PR with one. A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 15, 2020
@rust-highfive

rust-highfive commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2020
camelid
camelid commented Sep 15, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
camelid
camelid commented Sep 15, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs
@petrochenkov

petrochenkov commented Sep 15, 2020

Copy link
Copy Markdown
Contributor

r? @RalfJung maybe?
This all looks correct for basic blocks in general, but I'm not familiar with rustc specifics.

jyn514
jyn514 reviewed Sep 15, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
@camelidJoshua Nelson
Improve wording
c051f61
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
RalfJung
RalfJung reviewed Sep 16, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
RalfJung
RalfJung reviewed Sep 16, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
camelid
camelid commented Sep 16, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs Outdated
camelid
camelid commented Sep 17, 2020
View reviewed changes
Comment threadcompiler/rustc_middle/src/mir/mod.rs
@camelid

camelid commented Sep 19, 2020

Copy link
Copy Markdown
MemberAuthor

Okay, I think this is ready for a final review!

@RalfJung

RalfJung commented Sep 20, 2020

Copy link
Copy Markdown
Member

Looking good, thanks. :)
@bors r+ rollup

@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 451f7f6 has been approved by RalfJung

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
@RalfJung
Rollup merge ofrust-lang#76732- camelid:mir-basic-block-docs, r=Ral…
332b43f
…fJung
Add docs for `BasicBlock`
Fixesrust-lang#76715.
---
@rustbot modify labels: A-mir T-doc C-enhancement
This was referenced Sep 20, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
@bors
Auto merge ofrust-lang#76975- RalfJung:rollup-s2wiuqr, r=RalfJung
81e0270
Rollup of 15 pull requests
Successful merges:
- rust-lang#76732 (Add docs for `BasicBlock`)
- rust-lang#76832 (Let backends define custom targets)
- rust-lang#76866 (Remove unused feature gates from library/ crates)
- rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs)
- rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs)
- rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs)
- rust-lang#76878 (Move the version number to a plaintext file)
- rust-lang#76883 (README.md: Remove prompts from code blocks)
- rust-lang#76887 (Add missing examples on HashSet iter types)
- rust-lang#76890 (use matches!() macro for simple if let conditions)
- rust-lang#76891 (don't take `TyCtxt` by reference)
- rust-lang#76910 (transmute: use diagnostic item)
- rust-lang#76924 (Add tracking issue for feature(unix_socket_peek))
- rust-lang#76926 (BTreeMap: code readability tweaks)
- rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait)
Failed merges:
r? `@ghost`
@bors
bors merged commit 39b9a25 into rust-lang:masterSep 20, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 20, 2020
@camelid
camelid deleted the mir-basic-block-docs branch September 20, 2020 17:21
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RalfJungRalfJungRalfJung left review comments
@petrochenkovpetrochenkovpetrochenkov left review comments
@scottmcmscottmcmscottmcm left review comments
+1 more reviewer
@jyn514jyn514jyn514 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@RalfJungRalfJung

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-MIRArea: Mid-level IR (MIR) - https://blog.rust-lang.org/2016/04/19/MIR.htmlC-enhancementCategory: An issue proposing an enhancement or a PR with one.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

Add docs for mir::BasicBlock

8 participants

@camelid@rust-highfive@petrochenkov@RalfJung@bors@scottmcm@jyn514@rustbot