Skip to content

use matches!() macro for simple if let conditions - #76890

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:matches_simpl
Sep 20, 2020
Merged

use matches!() macro for simple if let conditions#76890
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:matches_simpl

Conversation

@matthiaskrgr

@matthiaskrgrmatthiaskrgr commented Sep 18, 2020

Copy link
Copy Markdown
Member

No description provided.

@rust-highfive

rust-highfive commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

r? @lcnr

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
lcnr
lcnr approved these changes Sep 18, 2020
View reviewed changes

@lcnrlcnr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The same nit 8 times which is mostly personal style. Otherwise r=me I guess

Comment threadcompiler/rustc_ast/src/ast.rs Outdated
Comment threadcompiler/rustc_ast/src/ast.rs Outdated

@lcnrlcnrSep 18, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
matches!(*self,VisibilityKind::Public)
matches!(self,VisibilityKind::Public)

Comment threadcompiler/rustc_ast_passes/src/ast_validation.rs Outdated
Comment threadcompiler/rustc_attr/src/builtin.rs Outdated
Comment threadcompiler/rustc_attr/src/builtin.rs Outdated
Comment threadcompiler/rustc_middle/src/middle/cstore.rs Outdated
Comment threadcompiler/rustc_mir/src/transform/promote_consts.rs Outdated
Comment threadcompiler/rustc_mir_build/src/build/block.rs Outdated
@lcnr

lcnr commented Sep 18, 2020

Copy link
Copy Markdown
Contributor

Thanks

@bors r+ rollup

@bors

bors commented Sep 18, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 40dddd3 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 18, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
@RalfJung
Rollup merge ofrust-lang#76890- matthiaskrgr:matches_simpl, r=lcnr
da24493
use matches!() macro for simple if let conditions
This was referenced Sep 20, 2020
Closed
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
@bors
Auto merge ofrust-lang#76975- RalfJung:rollup-s2wiuqr, r=RalfJung
81e0270
Rollup of 15 pull requests
Successful merges:
- rust-lang#76732 (Add docs for `BasicBlock`)
- rust-lang#76832 (Let backends define custom targets)
- rust-lang#76866 (Remove unused feature gates from library/ crates)
- rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs)
- rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs)
- rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs)
- rust-lang#76878 (Move the version number to a plaintext file)
- rust-lang#76883 (README.md: Remove prompts from code blocks)
- rust-lang#76887 (Add missing examples on HashSet iter types)
- rust-lang#76890 (use matches!() macro for simple if let conditions)
- rust-lang#76891 (don't take `TyCtxt` by reference)
- rust-lang#76910 (transmute: use diagnostic item)
- rust-lang#76924 (Add tracking issue for feature(unix_socket_peek))
- rust-lang#76926 (BTreeMap: code readability tweaks)
- rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait)
Failed merges:
r? `@ghost`
@bors
bors merged commit 8405d50 into rust-lang:masterSep 20, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 20, 2020
@matthiaskrgr
matthiaskrgr deleted the matches_simpl branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr approved these changes

Assignees

@lcnrlcnr

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.48.0

Development

Successfully merging this pull request may close these issues.

5 participants

@matthiaskrgr@rust-highfive@lcnr@bors@rustbot