Skip to content

Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs - #76876

Merged
bors merged 1 commit into
rust-lang:masterfrom
denisvasilik:intra-doc-links-alloc
Sep 20, 2020
Merged

Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs#76876
bors merged 1 commit into
rust-lang:masterfrom
denisvasilik:intra-doc-links-alloc

Conversation

@denisvasilik

Copy link
Copy Markdown
Contributor

Helps with #75080.

@rustbot modify labels: T-doc, A-intra-doc-links

@rustbotrustbot added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools labels Sep 18, 2020
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @LukasKalbertodt

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 18, 2020
@denisvasilik

Copy link
Copy Markdown
ContributorAuthor

r? @jyn514

@denisvasilik

Copy link
Copy Markdown
ContributorAuthor

std/collections/struct.BTreeMap.html:265: broken link fragment #insert-and-complex-keyspointing tostd/index.html``

I'm on it.

@jyn514jyn514 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with CI passing

Comment threadlibrary/alloc/src/collections/btree/map.rs Outdated
@denisvasilik

Copy link
Copy Markdown
ContributorAuthor

I think self#insert-and-complex-keys should be the correct link, but there's again the problem with private items. So I'm going to revert that change.

814 | /// [module-level documentation]: self#insert-and-complex-keys
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ this item is private

@jyn514

Copy link
Copy Markdown
Member

r=me with commits squashed, thanks for sticking with this! Let me know if you have trouble with git and I can help.

@denisvasilik

Copy link
Copy Markdown
ContributorAuthor

@bors r=jyn514

@bors

bors commented Sep 19, 2020

Copy link
Copy Markdown
Collaborator

@denisvasilik: 🔑 Insufficient privileges: Not in reviewers

@denisvasilik

Copy link
Copy Markdown
ContributorAuthor

r? @jyn514

@jyn514

Copy link
Copy Markdown
Member

@bors r+ rollup

Next time I'll @bors delegate denisvasilik, sorry about that

@bors

bors commented Sep 20, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit f9fa649 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 20, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 20, 2020
… r=jyn514
Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs
Helps with rust-lang#75080.
@rustbot modify labels: T-doc, A-intra-doc-links
This was referenced Sep 20, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 20, 2020
Rollup of 15 pull requests
Successful merges:
- rust-lang#76732 (Add docs for `BasicBlock`)
- rust-lang#76832 (Let backends define custom targets)
- rust-lang#76866 (Remove unused feature gates from library/ crates)
- rust-lang#76875 (Move to intra-doc links in library/alloc/src/collections/binary_heap.rs)
- rust-lang#76876 (Move to intra-doc links in collections/btree/map.rs and collections/linked_list.rs)
- rust-lang#76877 (Move to intra-doc links in collections/vec_deque.rs and collections/vec_deque/drain.rs)
- rust-lang#76878 (Move the version number to a plaintext file)
- rust-lang#76883 (README.md: Remove prompts from code blocks)
- rust-lang#76887 (Add missing examples on HashSet iter types)
- rust-lang#76890 (use matches!() macro for simple if let conditions)
- rust-lang#76891 (don't take `TyCtxt` by reference)
- rust-lang#76910 (transmute: use diagnostic item)
- rust-lang#76924 (Add tracking issue for feature(unix_socket_peek))
- rust-lang#76926 (BTreeMap: code readability tweaks)
- rust-lang#76940 (Don't allow implementing trait directly on type-alias-impl-trait)
Failed merges:
r? `@ghost`
@bors
bors merged commit 3941201 into rust-lang:masterSep 20, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 20, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-docsArea: Documentation for any part of the project, including the compiler, standard library, and toolsA-intra-doc-linksArea: Intra-doc links, the ability to link to items in docs by nameS-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@denisvasilik@rust-highfive@jyn514@bors@LukasKalbertodt@rustbot