Skip to content

Fix dest prop miscompilation around references - #77066

Merged
bors merged 2 commits into
rust-lang:masterfrom
jonas-schievink:dest-prop-borrow
Sep 25, 2020
Merged

Fix dest prop miscompilation around references#77066
bors merged 2 commits into
rust-lang:masterfrom
jonas-schievink:dest-prop-borrow

Conversation

@jonas-schievink

Copy link
Copy Markdown
Contributor

Closes#77002

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 22, 2020
@jonas-schievink

Copy link
Copy Markdown
ContributorAuthor

r? @oli-obk

@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 4b6a482 has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 22, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r-

you need to update mir-opt tests, too

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 22, 2020
@oli-obk

Copy link
Copy Markdown
Contributor

@bors r+

@bors

bors commented Sep 22, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 928a29f has been approved by oli-obk

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 22, 2020
ecstatic-morse added a commit to ecstatic-morse/rust that referenced this pull request Sep 22, 2020
…=oli-obk
Fix dest prop miscompilation around references
Closesrust-lang#77002
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 24, 2020
…=oli-obk
Fix dest prop miscompilation around references
Closesrust-lang#77002
This was referenced Sep 25, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2020
…as-schievink
Rollup of 15 pull requests
Successful merges:
- rust-lang#76932 (Relax promises about condition variable.)
- rust-lang#76973 (Unstably allow assume intrinsic in const contexts)
- rust-lang#77005 (BtreeMap: refactoring around edges)
- rust-lang#77066 (Fix dest prop miscompilation around references)
- rust-lang#77073 (dead_code: look at trait impls even if they don't contain items)
- rust-lang#77086 (Include libunwind in the rust-src component.)
- rust-lang#77097 (Make [].as_[mut_]ptr_range() (unstably) const.)
- rust-lang#77106 (clarify that `changelog-seen = 1` goes to the beginning of config.toml)
- rust-lang#77120 (Add `--keep-stage-std` to `x.py` for keeping only standard library artifacts)
- rust-lang#77126 (Invalidate local LLVM cache less often)
- rust-lang#77146 (Install std for non-host targets)
- rust-lang#77155 (remove enum name from ImplSource variants)
- rust-lang#77176 (Removing erroneous semicolon in transmute documentation)
- rust-lang#77183 (Allow multiple allow_internal_unstable attributes)
- rust-lang#77189 (Remove extra space from vec drawing)
Failed merges:
r? `@ghost`
@bors
bors merged commit 452aa75 into rust-lang:masterSep 25, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Miscompilation with mir-opt-level=2

6 participants

@jonas-schievink@rust-highfive@oli-obk@bors@eddyb@rustbot