Skip to content

clarify that changelog-seen = 1 goes to the beginning of config.toml - #77106

Merged
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:changelog_seen
Sep 25, 2020
Merged

clarify that changelog-seen = 1 goes to the beginning of config.toml#77106
bors merged 1 commit into
rust-lang:masterfrom
matthiaskrgr:changelog_seen

Conversation

@matthiaskrgr

Copy link
Copy Markdown
Member

Fixes#77105

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @Mark-Simulacrum

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 23, 2020
@Mark-Simulacrum

Copy link
Copy Markdown
Member

I think it can go anywhere, just needs to not be in a [section] -- I forget how those end in toml though. Maybe they don't.

This seems good enough for now.

@bors r+

@bors

bors commented Sep 23, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit b5d47bf has been approved by Mark-Simulacrum

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 23, 2020
@jyn514jyn514 added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label Sep 23, 2020
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Sep 24, 2020
…-Simulacrum
clarify that `changelog-seen = 1` goes to the beginning of config.toml
Fixesrust-lang#77105
@RalfJung

Copy link
Copy Markdown
Member

@bors rollup

RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 25, 2020
…-Simulacrum
clarify that `changelog-seen = 1` goes to the beginning of config.toml
Fixesrust-lang#77105
@RalfJungRalfJung mentioned this pull request Sep 25, 2020
RalfJung added a commit to RalfJung/rust that referenced this pull request Sep 25, 2020
…-Simulacrum
clarify that `changelog-seen = 1` goes to the beginning of config.toml
Fixesrust-lang#77105
@RalfJungRalfJung mentioned this pull request Sep 25, 2020
@pickfire

Copy link
Copy Markdown
Contributor

Or it could point them to look at the newer config.toml.

This was referenced Sep 25, 2020
bors added a commit to rust-lang-ci/rust that referenced this pull request Sep 25, 2020
…as-schievink
Rollup of 15 pull requests
Successful merges:
- rust-lang#76932 (Relax promises about condition variable.)
- rust-lang#76973 (Unstably allow assume intrinsic in const contexts)
- rust-lang#77005 (BtreeMap: refactoring around edges)
- rust-lang#77066 (Fix dest prop miscompilation around references)
- rust-lang#77073 (dead_code: look at trait impls even if they don't contain items)
- rust-lang#77086 (Include libunwind in the rust-src component.)
- rust-lang#77097 (Make [].as_[mut_]ptr_range() (unstably) const.)
- rust-lang#77106 (clarify that `changelog-seen = 1` goes to the beginning of config.toml)
- rust-lang#77120 (Add `--keep-stage-std` to `x.py` for keeping only standard library artifacts)
- rust-lang#77126 (Invalidate local LLVM cache less often)
- rust-lang#77146 (Install std for non-host targets)
- rust-lang#77155 (remove enum name from ImplSource variants)
- rust-lang#77176 (Removing erroneous semicolon in transmute documentation)
- rust-lang#77183 (Allow multiple allow_internal_unstable attributes)
- rust-lang#77189 (Remove extra space from vec drawing)
Failed merges:
r? `@ghost`
@bors
bors merged commit 8621ef1 into rust-lang:masterSep 25, 2020
@rustbotrustbot added this to the 1.48.0 milestone Sep 25, 2020
@matthiaskrgr
matthiaskrgr deleted the changelog_seen branch January 25, 2025 09:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-bootstrapRelevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rustbuild: "changelog-seen = 1" breaks config.toml

8 participants

@matthiaskrgr@rust-highfive@Mark-Simulacrum@bors@RalfJung@pickfire@jyn514@rustbot