Uh oh!
There was an error while loading. Please reload this page.
Include libunwind in the rust-src component. - #77086
Conversation
rust-highfive
commented
Sep 23, 2020
(rust_highfive has picked a reviewer for you, use r? to override) |
Mark-Simulacrum
commented
Sep 23, 2020
Hm, this is actually a bit concerning from a licensing perspective - libunwind appears to be Apache with LLVM exception, but we claim MIT or APACHE 2.0. Maybe we're okay because of the exception? r=me on the change itself, but I'll want to file an issue at least, will do so tomorrow (or feel free to do so, and approve) |
ehuss
commented
Sep 23, 2020
I was under the impression that libunwind was MIT OR BSD-Like. I also thought that these licenses for the runtime are ok (per LICENSES). Also, I don't think the license for As for the general license instructions for the standard library, I thought #67014 was the issue for that. Or are you referring to something else? |
Mark-Simulacrum
commented
Sep 23, 2020
bors
commented
Sep 23, 2020
📌 Commit 9f27f37 has been approved by |
Include libunwind in the rust-src component. Some targets, such as musl, need the libunwind source to build the unwind crate (referenced [here](https://github.com/rust-lang/rust/blob/0da58007451a154da2480160429e1604a1f5f0ec/library/unwind/build.rs#L142)). Fixesrust-lang/wg-cargo-std-aware#59
I don't think there's any issue here. libunwind, as pointed out in an earlier comment, has a more permissive license than the rest of LLVM. (Also, in general I don't think there'd be an issue if we wanted to include things under LLVM's normal license of |
RalfJung
commented
Sep 25, 2020
@bors rollup |
Include libunwind in the rust-src component. Some targets, such as musl, need the libunwind source to build the unwind crate (referenced [here](https://github.com/rust-lang/rust/blob/0da58007451a154da2480160429e1604a1f5f0ec/library/unwind/build.rs#L142)). Fixesrust-lang/wg-cargo-std-aware#59
Include libunwind in the rust-src component. Some targets, such as musl, need the libunwind source to build the unwind crate (referenced [here](https://github.com/rust-lang/rust/blob/0da58007451a154da2480160429e1604a1f5f0ec/library/unwind/build.rs#L142)). Fixesrust-lang/wg-cargo-std-aware#59
…as-schievink Rollup of 15 pull requests Successful merges: - rust-lang#76932 (Relax promises about condition variable.) - rust-lang#76973 (Unstably allow assume intrinsic in const contexts) - rust-lang#77005 (BtreeMap: refactoring around edges) - rust-lang#77066 (Fix dest prop miscompilation around references) - rust-lang#77073 (dead_code: look at trait impls even if they don't contain items) - rust-lang#77086 (Include libunwind in the rust-src component.) - rust-lang#77097 (Make [].as_[mut_]ptr_range() (unstably) const.) - rust-lang#77106 (clarify that `changelog-seen = 1` goes to the beginning of config.toml) - rust-lang#77120 (Add `--keep-stage-std` to `x.py` for keeping only standard library artifacts) - rust-lang#77126 (Invalidate local LLVM cache less often) - rust-lang#77146 (Install std for non-host targets) - rust-lang#77155 (remove enum name from ImplSource variants) - rust-lang#77176 (Removing erroneous semicolon in transmute documentation) - rust-lang#77183 (Allow multiple allow_internal_unstable attributes) - rust-lang#77189 (Remove extra space from vec drawing) Failed merges: r? `@ghost`
Some targets, such as musl, need the libunwind source to build the unwind crate (referenced here).
Fixesrust-lang/wg-cargo-std-aware#59