Skip to content

Enable building Cargo for aarch64-apple-darwin - #77239

Merged
bors merged 4 commits into
rust-lang:masterfrom
shepmaster:silicon-ci-plus
Oct 14, 2020
Merged

Enable building Cargo for aarch64-apple-darwin#77239
bors merged 4 commits into
rust-lang:masterfrom
shepmaster:silicon-ci-plus

Conversation

@shepmaster

@shepmastershepmaster commented Sep 26, 2020

Copy link
Copy Markdown
Member

@shepmaster

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@shepmaster

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@bors

bors commented Sep 26, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: ac7767935cf615cd80216919f4e2c62ea765d9ed (ac7767935cf615cd80216919f4e2c62ea765d9ed)

@shepmaster

shepmaster commented Sep 27, 2020

Copy link
Copy Markdown
MemberAuthor

@pietroalbini how would you feel about me submitting e51b507 and ddb8ed2 as a separate PR? TL;DR: they move the try job below all the other ones so that we can use a YAML anchor instead of copy-pasta the builder specs when we want to change what platforms are built by try. This is immensely helpful when trying anything besides the default x86-64 linux builds, which only take a few lines of config, compared to e.g. the macOS builders which are much more.

@shepmastershepmaster mentioned this pull request Sep 27, 2020
Merged
@shepmaster

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Sep 27, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: 9fa745e4c5f16139c128992e21a3f10a7589948d (9fa745e4c5f16139c128992e21a3f10a7589948d)

@emilyalbini

emilyalbini commented Sep 28, 2020

Copy link
Copy Markdown
Member

@pietroalbini how would you feel about me submitting e51b507 and ddb8ed2 as a separate PR? TL;DR: they move the try job below all the other ones so that we can use a YAML anchor instead of copy-pasta the builder specs when we want to change what platforms are built by try. This is immensely helpful when trying anything besides the default x86-64 linux builds, which only take a few lines of config, compared to e.g. the macOS builders which are much more.

Sounds good!

@bors

This comment has been minimized.

Sign in to view
@borsbors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Oct 1, 2020
@shepmaster
shepmasterforce-pushed the silicon-ci-plus branch 2 times, most recently from 2a8bd11 to 966b398CompareOctober 4, 2020 19:14
@shepmaster

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Oct 4, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: edb89086d353eb63b40774691d1025a9d073df03 (edb89086d353eb63b40774691d1025a9d073df03)

@shepmaster

This comment has been minimized.

Sign in to view
@bors

This comment has been minimized.

Sign in to view
@bors

bors commented Oct 12, 2020

Copy link
Copy Markdown
Collaborator

☀️ Try build successful - checks-actions, checks-azure
Build commit: bef4c2e0681c0c80fa79543d1c1e092cde44d838 (bef4c2e0681c0c80fa79543d1c1e092cde44d838)

@shepmastershepmaster changed the title Next steps on Silicon CIEnable building Cargo for aarch64-apple-darwinOct 12, 2020
@shepmaster

shepmaster commented Oct 12, 2020

Copy link
Copy Markdown
MemberAuthor

r? @pietroalbini

/cc @Mark-Simulacrum

@shepmaster
shepmaster marked this pull request as ready for review October 12, 2020 20:33
@emilyalbini

emilyalbini commented Oct 13, 2020

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit eb0c996 has been approved by pietroalbini

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 13, 2020
@shepmaster

shepmaster commented Oct 13, 2020

Copy link
Copy Markdown
MemberAuthor

@bors r=@pietroalbini

@bors

bors commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 8b6e346 has been approved by pietroalbini

@bors

bors commented Oct 13, 2020

Copy link
Copy Markdown
Collaborator

⌛ Testing commit 8b6e346 with merge f715f43d4d1e850ef807de9f4c08de4e5e1517cc...

JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 13, 2020
@JohnTitor
Rollup merge ofrust-lang#77239- shepmaster:silicon-ci-plus, r=pietr…
ccd3914
…oalbini
Enable building Cargo for aarch64-apple-darwin
r? @ghost
@JohnTitorJohnTitor mentioned this pull request Oct 13, 2020
Closed
@JohnTitor

JohnTitor commented Oct 13, 2020

Copy link
Copy Markdown
Member

@bors retry yielding

@JohnTitorJohnTitor mentioned this pull request Oct 13, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 13, 2020
@bors
Auto merge ofrust-lang#77917- JohnTitor:rollup-e47h2qt, r=JohnTitor
f243a2a
Rollup of 14 pull requests
Successful merges:
- rust-lang#77239 (Enable building Cargo for aarch64-apple-darwin)
- rust-lang#77569 (BTreeMap: type-specific variants of node_as_mut and cast_unchecked)
- rust-lang#77719 (Remove unnecessary rustc_const_stable attributes.)
- rust-lang#77722 (Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn).)
- rust-lang#77725 (Add regression issue template)
- rust-lang#77776 ( Give an error when running `x.py test --stage 0 src/test/ui`)
- rust-lang#77786 (Mention rustdoc in `x.py setup`)
- rust-lang#77825 (`min_const_generics` diagnostics improvements)
- rust-lang#77868 (Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component)
- rust-lang#77884 (Use Option::unwrap_or instead of open-coding it)
- rust-lang#77886 (Replace trivial bool matches with the `matches!` macro)
- rust-lang#77892 (Replace absolute paths with relative ones)
- rust-lang#77895 (Include aarch64-apple-darwin in the dist manifests)
- rust-lang#77909 (bootstrap: set correct path for the build-manifest binary)
Failed merges:
- rust-lang#77902 (Include aarch64-pc-windows-msvc in the dist manifests)
r? `@ghost`
@bors
bors merged commit 16612a9 into rust-lang:masterOct 14, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 14, 2020
@shepmaster
shepmaster deleted the silicon-ci-plus branch October 14, 2020 00:38
@shepmastershepmaster mentioned this pull request Oct 14, 2020
Closed
31 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@emilyalbiniemilyalbini

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

6 participants

@shepmaster@bors@rust-log-analyzer@emilyalbini@JohnTitor@rustbot