Uh oh!
There was an error while loading. Please reload this page.
Rollup of 14 pull requests - #77917
Merged
Merged
Conversation
Replacing the UnsafeCell by a Cell simplifies things and makes it all safe.
Replacing the UnsafeCell by a Cell makes it all safe.
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
This also allows 'rustdoc' as a string for the compiler profile.
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Co-authored-by: varkor <github@varkor.com>
Fixesrust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
Modern compilers allow reaching external crates like std or core via relative paths in modules outside of lib.rs and main.rs.
…oalbini Enable building Cargo for aarch64-apple-darwin r? @ghost
…ulacrum BTreeMap: type-specific variants of node_as_mut and cast_unchecked Improves debug checking and shortens some expressions. Extracted from rust-lang#77408
…mutex-attr-cleanup, r=Mark-Simulacrum Remove unnecessary rustc_const_stable attributes. These attributes were added in rust-lang#74033 (comment) because of [std::io::lazy::Lazy::new](https://github.com/rust-lang/rust/blob/0c03aee8b81185d65b5821518661c30ecdb42de5/src/libstd/io/lazy.rs#L21-L23). But [std::io::lazy::Lazy is gone now](rust-lang#77154), so this can be cleaned up. @rustbot modify labels: +T-libs +C-cleanup
…ported-locks, r=Mark-Simulacrum Remove unsafety from sys/unsupported and add deny(unsafe_op_in_unsafe_fn). Replacing `UnsafeCell`s by a `Cell`s simplifies things and makes the mutex and rwlock implementations safe. Other than that, only unsafety in strlen() contained unsafe code. @rustbot modify labels: +F-unsafe-block-in-unsafe-fn +C-cleanup
…-Simulacrum Add regression issue template Feel free to suggest improvements!
Give an error when running `x.py test --stage 0 src/test/ui` The error can be overridden with `COMPILETEST_FORCE_STAGE0=1`. In practice I don't know why anyone would do this. r? @Mark-SimulacrumClosesrust-lang#77711
Mention rustdoc in `x.py setup` This lets new contributors know which option they should pick; previously it wasn't clear 'compiler' also included rustdoc. Unresolved questions: should this say 'compiler and tools' instead? I don't know of any tools that are modified in-tree other than rustdoc, though. r? @Mark-Simulacrum
…stic, r=lcnr `min_const_generics` diagnostics improvements As disscussed in [zulip/project-const-generics/non-trivial anonymous constant](https://rust-lang.zulipchat.com/#narrow/stream/260443-project-const-generics/topic/non-trivial.20anonymous.20constants). This is my first PR on the compiler. @lcnr is mentoring me on this PR. Related to rust-lang#60551.
…k-Simulacrum Include `llvm-dis`, `llc` and `opt` in `llvm-tools-preview` component Fixesrust-lang#55890 It's useful to have `llc` and `opt` available when debugging an LLVM miscompilation,.
Use Option::unwrap_or instead of open-coding it
…petrochenkov Replace trivial bool matches with the `matches!` macro This derives `PartialEq` on one enum (and two structs it contains) to enable the `==` operator for it. If there's some downside to this, I could respin with the `matches!` macro instead.
…hs, r=lcnr Replace absolute paths with relative ones Modern compilers allow reaching external crates like std or core via relative paths in modules outside of lib.rs and main.rs.
…roalbini Include aarch64-apple-darwin in the dist manifests r? @ehuss /cc @pietroalbini@Mark-Simulacrum
…h, r=Mark-Simulacrum
bootstrap: set correct path for the build-manifest binary
This changes the path of the binary inside the tarball to be:
```
build-manifest-{release}-{target}/build-manifest/bin/build-manifest
```
...instead of:
```
build-manifest-{release}-{target}/build-manifest/bin/build-manifest/build-manifest
```
r? @Mark-SimulacrumJohnTitor
commented
Oct 13, 2020
MemberAuthor
bors
commented
Oct 13, 2020
Collaborator
📌 Commit b4a3b56 has been approved by |
bors
commented
Oct 13, 2020
Collaborator
bors
commented
Oct 14, 2020
Collaborator
☀️ Test successful - checks-actions, checks-azure |
This was referenced Oct 14, 2020
This was referenced Oct 14, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
x.py test --stage 0 src/test/ui#77776 ( Give an error when runningx.py test --stage 0 src/test/ui)x.py setup#77786 (Mention rustdoc inx.py setup)min_const_genericsdiagnostics improvements #77825 (min_const_genericsdiagnostics improvements)llvm-dis,llcandoptinllvm-tools-previewcomponent #77868 (Includellvm-dis,llcandoptinllvm-tools-previewcomponent)matches!macro #77886 (Replace trivial bool matches with thematches!macro)Failed merges:
r? @ghost