Skip to content

Reorder benches const variable - #77334

Merged
bors merged 1 commit into
rust-lang:masterfrom
pickfire:patch-4
Oct 30, 2020
Merged

Reorder benches const variable#77334
bors merged 1 commit into
rust-lang:masterfrom
pickfire:patch-4

Conversation

@pickfire

@pickfirepickfire commented Sep 29, 2020

Copy link
Copy Markdown
Contributor

Move LEN so it is is read in order.

@pickfire
Reorder benches const variable
55ba9e4
Move LEN so it is is read in order.
@rust-highfive

rust-highfive commented Sep 29, 2020

Copy link
Copy Markdown
Contributor

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 29, 2020
@pickfire

pickfire commented Sep 29, 2020

Copy link
Copy Markdown
ContributorAuthor

@pickfire change once instead of [0].iter() after this.

@rustbot modify labels: +C-cleanup +A-testsuite

@rustbotrustbot added A-testsuite Area: The testsuite used to check the correctness of rustc C-cleanup Category: PRs that clean code up or issues documenting cleanup. labels Sep 29, 2020
@LeSeulArtichautLeSeulArtichaut added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 16, 2020
@jyn514

jyn514 commented Oct 30, 2020

Copy link
Copy Markdown
Member

@bors r+ rollup

@bors

bors commented Oct 30, 2020

Copy link
Copy Markdown
Collaborator

📌 Commit 55ba9e4 has been approved by jyn514

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 30, 2020
@JohnTitorJohnTitor mentioned this pull request Oct 30, 2020
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 30, 2020
@bors
Auto merge ofrust-lang#78562- JohnTitor:rollup-otg906u, r=JohnTitor
388ef34
Rollup of 8 pull requests
Successful merges:
- rust-lang#77334 (Reorder benches const variable)
- rust-lang#77888 (Simplify a nested bool match)
- rust-lang#77921 (f64: Refactor collapsible_if)
- rust-lang#78523 (Revert invalid `fn` return type parsing change)
- rust-lang#78524 (Avoid BorrowMutError with RUSTC_LOG=debug)
- rust-lang#78545 (Make anonymous binders start at 0)
- rust-lang#78554 (Improve wording of `core::ptr::drop_in_place` docs)
- rust-lang#78556 (Link to pass docs from NRVO module docs)
Failed merges:
- rust-lang#78424 (Fix some more clippy warnings)
r? `@ghost`
@bors
bors merged commit 0723b27 into rust-lang:masterOct 30, 2020
@rustbotrustbot added this to the 1.49.0 milestone Oct 30, 2020
@pickfire
pickfire deleted the patch-4 branch October 30, 2020 16:57
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@sfacklersfackler

Labels

A-testsuiteArea: The testsuite used to check the correctness of rustcC-cleanupCategory: PRs that clean code up or issues documenting cleanup.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-libsRelevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.49.0

Development

Successfully merging this pull request may close these issues.

7 participants

@pickfire@rust-highfive@jyn514@bors@sfackler@LeSeulArtichaut@rustbot