Uh oh!
There was an error while loading. Please reload this page.
Fix some more clippy warnings - #78424
Merged
Merged
Conversation
rust-highfive
commented
Oct 27, 2020
Contributor
r? @davidtwco (rust_highfive has picked a reviewer for you, use r? to override) |
petrochenkov
commented
Oct 27, 2020
Contributor
Looks like autofix removed some comments, they need to be restored. |
jyn514
commented
Oct 27, 2020
MemberAuthor
See rust-lang/rustfix#190 for discussion about fixing this in |
This comment has been minimized.
This comment has been minimized.
jyn514force-pushed
the
THE-PAPERCLIP-COMETH
branch
from
October 28, 2020 17:33
77e8ece to
5a19ae3Comparedavidtwco
commented
Oct 29, 2020
Member
@bors r+ |
bors
commented
Oct 29, 2020
Collaborator
📌 Commit 5a19ae3a87955a97156c096980b5e5d5b3654408 has been approved by |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 30, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#77334 (Reorder benches const variable) - rust-lang#77888 (Simplify a nested bool match) - rust-lang#77921 (f64: Refactor collapsible_if) - rust-lang#78523 (Revert invalid `fn` return type parsing change) - rust-lang#78524 (Avoid BorrowMutError with RUSTC_LOG=debug) - rust-lang#78545 (Make anonymous binders start at 0) - rust-lang#78554 (Improve wording of `core::ptr::drop_in_place` docs) - rust-lang#78556 (Link to pass docs from NRVO module docs) Failed merges: - rust-lang#78424 (Fix some more clippy warnings) r? `@ghost`
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jyn514force-pushed
the
THE-PAPERCLIP-COMETH
branch
from
October 30, 2020 14:13
5a19ae3 to
5339bd1Comparejyn514
commented
Oct 30, 2020
MemberAuthor
@bors r=davidtwco |
bors
commented
Oct 30, 2020
Collaborator
📌 Commit 5339bd1 has been approved by |
bors
commented
Oct 30, 2020
Collaborator
bors
commented
Oct 30, 2020
Collaborator
☀️ Test successful - checks-actions |
This was referenced Oct 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while working on #77351. It turns out that
x.py clippy --fixdoes work on that branch as long as you passCARGOFLAGS=--lib.