Uh oh!
There was an error while loading. Please reload this page.
Rollup of 8 pull requests - #78562
Merged
Merged
Conversation
Move LEN so it is is read in order.
Signed-off-by: wcampbell <wcampbell1995@gmail.com>
Logically this first eliminates the innermost match by merging the patterns. Then, in a second step, turns the newly innermost match into a `matches!` call.
$ touch empty.rs $ env RUSTC_LOG=debug rustc +stage1 --crate-type=lib empty.rs Fails with a `BorrowMutError` because source map files are already borrowed while `features_query` attempts to format a log message containing a span. Release the borrow before the query to avoid the issue.
And two small intra-doc link conversions in `std::{f32, f64}`.Reorder benches const variable Move LEN so it is is read in order.
…, r=jyn514 Simplify a nested bool match Logically this first eliminates the innermost match by merging the patterns. Then, in a second step, turns the newly innermost match into a `matches!` call.
…=jyn514 f64: Refactor collapsible_if
…ession, r=dtolnay Revert invalid `fn` return type parsing change Revert one of the changes in rust-lang#78379. Fixrust-lang#78507.
…n1011 Avoid BorrowMutError with RUSTC_LOG=debug ```console $ touch empty.rs $ env RUSTC_LOG=debug rustc +stage1 --crate-type=lib empty.rs ``` Fails with a `BorrowMutError` because source map files are already borrowed while `features_query` attempts to format a log message containing a span. Release the borrow before the query to avoid the issue.
Make anonymous binders start at 0 A few changes to some test outputs, but these actually look *more* correct to me.
…wording, r=jyn514
Improve wording of `core::ptr::drop_in_place` docs
And two small intra-doc link conversions in `std::{f32, f64}`.Link to pass docs from NRVO module docs It can be easy to miss that this is documented on the pass's struct if you are looking at the module docs. Cc https://rust-lang.zulipchat.com/#narrow/stream/189540-t-compiler.2Fwg-mir-opt/topic/what.20is.20NRVO.3F
JohnTitor
commented
Oct 30, 2020
MemberAuthor
bors
commented
Oct 30, 2020
Collaborator
📌 Commit 2471a7c has been approved by |
bors
commented
Oct 30, 2020
Collaborator
bors
commented
Oct 30, 2020
Collaborator
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
fnreturn type parsing change #78523 (Revert invalidfnreturn type parsing change)core::ptr::drop_in_placedocs #78554 (Improve wording ofcore::ptr::drop_in_placedocs)Failed merges:
r? @ghost