Uh oh!
There was an error while loading. Please reload this page.
2229: Consume IfLet expr - #89282
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| self.consume_expr(e) | ||
| } else if let Some(hir::Guard::IfLet(_, ref e)) = arm.guard { | ||
| self.consume_expr(e) | ||
| } |
Contributor
There was a problem hiding this comment.
This can be an exhaustive match
nikomatsakis
commented
Sep 30, 2021
Contributor
@bors r+ p=1 |
bors
commented
Sep 30, 2021
Collaborator
📌 Commit d0e2b60 has been approved by |
nikomatsakis
commented
Sep 30, 2021
Contributor
Nominating for beta backport, I believe this affects the Rust 2021 edition that is in beta. |
bors
commented
Sep 30, 2021
Collaborator
bors
commented
Sep 30, 2021
Collaborator
☀️ Test successful - checks-actions |
rust-timer
commented
Oct 1, 2021
Collaborator
Finished benchmarking commit (aa7aca3): comparison url. Summary: This benchmark run did not return any relevant changes. If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression |
apiraino
commented
Oct 7, 2021
Contributor
Merged
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 14, 2021
[beta] backports - 2229: Consume IfLet expr rust-lang#89282 - Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor rust-lang#89288 - Fix unsound optimization with explicit variant discriminants rust-lang#89489 - Fix stabilization version for bindings_after_at rust-lang#89605 - Turn vtable_allocation() into a query rust-lang#89619 - Revert "Stabilize Iterator::intersperse()" rust-lang#89638 - Ignore type of projections for upvar capturing rust-lang#89648 - ~~Add Poll::ready and~~ revert stabilization of task::ready! rust-lang#89651 - CI: Use mirror for libisl downloads for more docker dist builds rust-lang#89661 - Use correct edition for panic in [debug_]assert!(). rust-lang#89622 - Switch to our own mirror of libisl plus ct-ng oldconfig fixesrust-lang#89599 - Emit item no type error even if type inference fails rust-lang#89585 - Revert enum discriminants rust-lang#89884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the IfLet guard feature, we can ICE when attempting to resolve PlaceBuilders.
For pattern matching, we currently don't consume the IfLet expression when "visiting" the arms leading us to not "read" all variables and hence not being able to resolve them.
r? @nikomatsakis
Closes#88118