Skip to content

Switch to our own mirror of libisl plus ct-ng oldconfig fixes - #89599

Merged
bors merged 2 commits into
rust-lang:masterfrom
rusticstuff:ci-fix
Oct 6, 2021
Merged

Switch to our own mirror of libisl plus ct-ng oldconfig fixes#89599
bors merged 2 commits into
rust-lang:masterfrom
rusticstuff:ci-fix

Conversation

@hkratz

@hkratzhkratz commented Oct 6, 2021

Copy link
Copy Markdown
Contributor

Switching to mirror the ISL libs (#89594) unearthed a (possibly long-standing?) issue with ct-ng oldconfig. It always overwrites the mirror config values. This PR adds the ISL mirror, gets rid of ct-ng oldconfig and adds crosstools-ng config files which can be used directly. (Edited)

Fixes#89593.

r? @pietroalbini

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2021
@hkratz
hkratz marked this pull request as draft October 6, 2021 15:09
@hkratz

Copy link
Copy Markdown
ContributorAuthor

Still something wrong with it, looking...

@hkratz

Copy link
Copy Markdown
ContributorAuthor

Checking the arm builds locally, will mark as non-draft once done.

@hkratzhkratz changed the title Switch to our own mirror of libisl + armhf ct-ng oldconfigfixSwitch to our own mirror of libisl ct-ng oldconfig fixesOct 6, 2021
@hkratzhkratz changed the title Switch to our own mirror of libisl ct-ng oldconfig fixesSwitch to our own mirror of libisl plus ct-ng oldconfig fixesOct 6, 2021
@hkratz

hkratz commented Oct 6, 2021

Copy link
Copy Markdown
ContributorAuthor

ct-ng builds seem to work locally now.

@hkratz
hkratz marked this pull request as ready for review October 6, 2021 16:51
@Mark-Simulacrum

Copy link
Copy Markdown
Member

@bors r+ p=101

@bors

bors commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit b5f9cdb has been approved by Mark-Simulacrum

@bors

bors commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2021
@bors

bors commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

⌛ Testing commit b5f9cdb with merge d480cef...

@bors

bors commented Oct 6, 2021

Copy link
Copy Markdown
Collaborator

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing d480cef to master...

@borsbors added the merged-by-bors This PR was explicitly merged by bors. label Oct 6, 2021
@bors
bors merged commit d480cef into rust-lang:masterOct 6, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 6, 2021
@rust-timer

Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (d480cef): comparison url.

Summary: This benchmark run did not return any relevant changes.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 10, 2021
…=Mark-Simulacrum
CI: Use mirror for libisl downloads for more docker dist builds
http://isl.gforge.inria.fr fell from the net a couple of days ago. It hosts libisl source tarballs required by crosstool-ng, which we use for our docker dist cross-compilation builds. Some of the affected builds were already fixed in rust-lang#89599.
This PR sets a mirror URL for the other builds requiring libisl-0.14. They use an older version of crosstool-ng (1.22.0), which has only one mirror setting for all downloads.
r? `@Mark-Simulacrum`
@hkratzhkratz mentioned this pull request Oct 13, 2021
@Mark-SimulacrumMark-Simulacrum added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 14, 2021
@Mark-SimulacrumMark-Simulacrum removed this from the 1.57.0 milestone Oct 14, 2021
@Mark-SimulacrumMark-Simulacrum added this to the 1.56.0 milestone Oct 14, 2021
@Mark-SimulacrumMark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 14, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2021
[beta] backports
- 2229: Consume IfLet expr rust-lang#89282
- Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor rust-lang#89288
- Fix unsound optimization with explicit variant discriminants rust-lang#89489
- Fix stabilization version for bindings_after_at rust-lang#89605
- Turn vtable_allocation() into a query rust-lang#89619
- Revert "Stabilize Iterator::intersperse()" rust-lang#89638
- Ignore type of projections for upvar capturing rust-lang#89648
- ~~Add Poll::ready and~~ revert stabilization of task::ready! rust-lang#89651
- CI: Use mirror for libisl downloads for more docker dist builds rust-lang#89661
- Use correct edition for panic in [debug_]assert!(). rust-lang#89622
- Switch to our own mirror of libisl plus ct-ng oldconfig fixesrust-lang#89599
- Emit item no type error even if type inference fails rust-lang#89585
- Revert enum discriminants rust-lang#89884
@hkratz
hkratz deleted the ci-fix branch November 6, 2021 20:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.merged-by-borsThis PR was explicitly merged by bors.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Github builders fails to download isl-0.20 for crossbuild

7 participants

@hkratz@Mark-Simulacrum@bors@rust-timer@emilyalbini@rust-highfive@rustbot