Skip to content

Fix stabilization version for bindings_after_at - #89605

Merged
bors merged 1 commit into
rust-lang:masterfrom
camelid:fix-version
Oct 9, 2021
Merged

Fix stabilization version for bindings_after_at#89605
bors merged 1 commit into
rust-lang:masterfrom
camelid:fix-version

Conversation

@camelid

Copy link
Copy Markdown
Member

According to the release notes and its PR milestone, it was stabilized
in 1.56.0.

According to the release notes and its PR milestone, it was stabilized
in 1.56.0.
@camelidcamelid added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Oct 6, 2021
@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 6, 2021
@camelid

Copy link
Copy Markdown
MemberAuthor

Is it worth backporting this PR to 1.56.0? Maybe not, but I'll nominate so the compiler team can decide.

@camelidcamelid added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 6, 2021
@apiraino

Copy link
Copy Markdown
Contributor

Beta backport accepted as per compiler team on Zulip

@rustbot label +beta-accepted

@rustbotrustbot added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 7, 2021
@nagisa

Copy link
Copy Markdown
Member

@bors r+

@bors

bors commented Oct 8, 2021

Copy link
Copy Markdown
Collaborator

📌 Commit 6189d0a has been approved by nagisa

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 8, 2021
@nagisa

Copy link
Copy Markdown
Member

I verified that this feature is indeed stable in today's beta (to be 1.56) and still unstable in 1.55.

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Oct 8, 2021
Fix stabilization version for `bindings_after_at`
According to the release notes and its PR milestone, it was stabilized
in 1.56.0.
@camelidcamelid assigned nagisa and unassigned jackh726Oct 8, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 9, 2021
Fix stabilization version for `bindings_after_at`
According to the release notes and its PR milestone, it was stabilized
in 1.56.0.
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 9, 2021
…askrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#88707 (String.split_terminator: Add an example when using a slice of chars)
- rust-lang#89605 (Fix stabilization version for `bindings_after_at`)
- rust-lang#89634 (rustc_driver: Enable the `WARN` log level by default)
- rust-lang#89641 (make #[target_feature] work with `asm` register classes)
- rust-lang#89678 (Fix minor std::thread documentation typo)
- rust-lang#89684 (Fix asm docs typo)
- rust-lang#89687 (Move `read2_abbreviated` function into read2.rs)
- rust-lang#89693 (Add #[must_use] to stdin/stdout/stderr locks)
- rust-lang#89694 (Add #[must_use] to string/char transformation methods)
- rust-lang#89697 (Fix min LLVM version for bpf-types test)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 03a34a2 into rust-lang:masterOct 9, 2021
@rustbotrustbot added this to the 1.57.0 milestone Oct 9, 2021
@camelid
camelid deleted the fix-version branch October 9, 2021 16:36
@cuvipercuviper mentioned this pull request Oct 13, 2021
@cuvipercuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 13, 2021
@cuvipercuviper removed this from the 1.57.0 milestone Oct 13, 2021
@cuvipercuviper added this to the 1.56.0 milestone Oct 13, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 14, 2021
[beta] backports
- 2229: Consume IfLet expr rust-lang#89282
- Wrapper for -Z gcc-ld=lld to invoke rust-lld with the correct flavor rust-lang#89288
- Fix unsound optimization with explicit variant discriminants rust-lang#89489
- Fix stabilization version for bindings_after_at rust-lang#89605
- Turn vtable_allocation() into a query rust-lang#89619
- Revert "Stabilize Iterator::intersperse()" rust-lang#89638
- Ignore type of projections for upvar capturing rust-lang#89648
- ~~Add Poll::ready and~~ revert stabilization of task::ready! rust-lang#89651
- CI: Use mirror for libisl downloads for more docker dist builds rust-lang#89661
- Use correct edition for panic in [debug_]assert!(). rust-lang#89622
- Switch to our own mirror of libisl plus ct-ng oldconfig fixesrust-lang#89599
- Emit item no type error even if type inference fails rust-lang#89585
- Revert enum discriminants rust-lang#89884
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-acceptedAccepted for backporting to the compiler in the beta channel.S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@camelid@rust-highfive@apiraino@nagisa@bors@cuviper@jackh726@rustbot