Uh oh!
There was an error while loading. Please reload this page.
Fix #98260 - #98642
Merged
Merged
Conversation
rust-highfive
commented
Jun 28, 2022
Contributor
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @petrochenkov (or someone else) soon. Please see the contribution instructions for more information. |
compiler-errors
commented
Jun 28, 2022
Contributor
@yanchen4791 this needs a test at least |
yanchen4791
commented
Jun 28, 2022
Author
Please note that the fix is for #98260 (not 98062). |
Member
@yanchen4791 you would probably want to place a test somewhere inside fnmain(){}traitA{fna(aa:B) -> Result<_,B>{Ok(())}}enumB{}And proper error proves. Check how tests are layed out in |
spastorino
commented
Jun 28, 2022
Member
And you would need to |
yanchen4791force-pushed
the
issue-98260-fix
branch
from
June 28, 2022 22:04
d29e320 to
0b3b20eCompare
yanchen4791force-pushed
the
issue-98260-fix
branch
from
June 28, 2022 22:22
0b3b20e to
f97326dCompareyanchen4791
commented
Jun 29, 2022
Author
@compiler-errors A test case has been added. |
spastorino
commented
Jun 29, 2022
Member
@bors r+ |
bors
commented
Jun 29, 2022
Collaborator
📌 Commit f97326d has been approved by |
jackh726
commented
Jun 29, 2022
Member
@bors rollup=never This might have a perf effect |
bors added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 29, 2022
…askrgr Rollup of 10 pull requests Successful merges: - rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.) - rust-lang#98636 (Triagebot: Fix mentions word wrapping.) - rust-lang#98642 (Fixrust-lang#98260) - rust-lang#98643 (Improve pretty printing of valtrees for references) - rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings) - rust-lang#98647 (Update cargo) - rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling` builds are warning-free) - rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.) - rust-lang#98665 (Use verbose help for deprecation suggestion) - rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#98260