Skip to content

Improve pretty printing of valtrees for references - #98643

Merged
bors merged 4 commits into
rust-lang:masterfrom
voidc:valtree-ref-pretty
Jun 29, 2022
Merged

Improve pretty printing of valtrees for references#98643
bors merged 4 commits into
rust-lang:masterfrom
voidc:valtree-ref-pretty

Conversation

@voidc

@voidcvoidc commented Jun 28, 2022

Copy link
Copy Markdown
Contributor

This implements the changes outlined in #66451 (comment).

r? @lcnr
Fixes#66451

@rustbot

rustbot commented Jun 28, 2022

Copy link
Copy Markdown
Collaborator

Some changes occurred to the CTFE / Miri engine

cc @rust-lang/miri

@rustbotrustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 28, 2022
@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
lcnr
lcnr reviewed Jun 28, 2022
View reviewed changes

@lcnrlcnr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some possible further improvements to destructure_const, then r=me

thanks ❤️

Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated
Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated
Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated
Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated
lcnr
lcnr reviewed Jun 29, 2022
View reviewed changes
Comment threadcompiler/rustc_ty_utils/src/consts.rs Outdated
lcnr
lcnr reviewed Jun 29, 2022
View reviewed changes
Comment threadcompiler/rustc_middle/src/query/mod.rs Outdated
@lcnr

lcnr commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

@bors delegate+

@bors

bors commented Jun 29, 2022

Copy link
Copy Markdown
Collaborator

✌️ @voidc can now approve this pull request

@lcnr

lcnr commented Jun 29, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

with @bors delegate+ you can do @bors r=<name-of-reviewer> yourself, without having to wait for the reviewer to look at your last changes.

@bors r+ rollup

@bors

bors commented Jun 29, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d048b15 has been approved by ```

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
@lcnr

lcnr commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

gdi bors xd

@lcnr

lcnr commented Jun 29, 2022

Copy link
Copy Markdown
Contributor

@bors r-
@bors r+

@borsbors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 29, 2022
@bors

bors commented Jun 29, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit d048b15 has been approved by lcnr

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 29, 2022
@matthiaskrgrmatthiaskrgr mentioned this pull request Jun 29, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2022
@bors
Auto merge ofrust-lang#98680- matthiaskrgr:rollup-1bkrrn9, r=matthi…
ddcbba0
…askrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.)
- rust-lang#98636 (Triagebot: Fix mentions word wrapping.)
- rust-lang#98642 (Fixrust-lang#98260)
- rust-lang#98643 (Improve pretty printing of valtrees for references)
- rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings)
- rust-lang#98647 (Update cargo)
- rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling` builds are warning-free)
- rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.)
- rust-lang#98665 (Use verbose help for deprecation suggestion)
- rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 921e311 into rust-lang:masterJun 29, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jun 29, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcnrlcnrlcnr left review comments

Assignees

@lcnrlcnr

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.64.0

Development

Successfully merging this pull request may close these issues.

Replace Debug representation in const value pretty print

5 participants

@voidc@rustbot@lcnr@bors@rust-highfive