Skip to content

rustdoc: fix bugs in main.js popover help and settings - #98646

Merged
bors merged 4 commits into
rust-lang:masterfrom
notriddle:notriddle/main.js
Jun 29, 2022
Merged

rustdoc: fix bugs in main.js popover help and settings#98646
bors merged 4 commits into
rust-lang:masterfrom
notriddle:notriddle/main.js

Conversation

@notriddle

Copy link
Copy Markdown
Contributor

No description provided.

@rustbotrustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Jun 28, 2022
@rustbot

Copy link
Copy Markdown
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @Folyd, @jsha

@rust-highfive

Copy link
Copy Markdown
Contributor

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfiverust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 28, 2022
@notriddle
notriddleforce-pushed the notriddle/main.js branch 2 times, most recently from d35ee57 to 4f91236CompareJune 28, 2022 23:53
This commit fixes the keyboard shorts code to call localStorage every time a
key is pressed. This matters because you're supposed to be able to change a
setting and have it immediately take effect.
@GuillaumeGomez

Copy link
Copy Markdown
Member

Great catch, thanks for the fix and the improvement!

@bors r+ rollup

@bors

bors commented Jun 29, 2022

Copy link
Copy Markdown
Collaborator

📌 Commit ccea908 has been approved by GuillaumeGomez

@borsbors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 29, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jun 29, 2022
…laumeGomez
rustdoc: fix bugs in main.js popover help and settings
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 29, 2022
…askrgr
Rollup of 10 pull requests
Successful merges:
- rust-lang#98434 (Ensure that `static_crt` is set in the bootstrapper whenever using `cc-rs` to get a compiler command line.)
- rust-lang#98636 (Triagebot: Fix mentions word wrapping.)
- rust-lang#98642 (Fixrust-lang#98260)
- rust-lang#98643 (Improve pretty printing of valtrees for references)
- rust-lang#98646 (rustdoc: fix bugs in main.js popover help and settings)
- rust-lang#98647 (Update cargo)
- rust-lang#98652 (`alloc`: clean and ensure `no_global_oom_handling` builds are warning-free)
- rust-lang#98660 (Unbreak stage1 tests via ignore-stage1 in `proc-macro/invalid-punct-ident-1.rs`.)
- rust-lang#98665 (Use verbose help for deprecation suggestion)
- rust-lang#98668 (Avoid some `&str` to `String` conversions with `MultiSpan::push_span_label`)
Failed merges:
r? `@ghost`
`@rustbot` modify labels: rollup
@bors
bors merged commit 1fef19a into rust-lang:masterJun 29, 2022
@rustbotrustbot added this to the 1.64.0 milestone Jun 29, 2022
@notriddle
notriddle deleted the notriddle/main.js branch June 29, 2022 21:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-borsStatus: Waiting on bors to run and complete tests. Bors will change the label on completion.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@notriddle@rustbot@rust-highfive@GuillaumeGomez@bors@jsha