Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,7 +19,7 @@ jobs:
fail-fast: false
matrix:
include:
- {os: windows-latest, python: "3.11", dask-version: "2025.2.0", name: "Dask 2025.2.0"}
- {os: windows-latest, python: "3.11", dask-version: "2025.12.0", name: "Dask 2025.12.0"}
- {os: windows-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.11", dask-version: "latest", name: "Dask latest"}
- {os: ubuntu-latest, python: "3.13", dask-version: "latest", name: "Dask latest"}
Expand Down
17 changes: 17 additions & 0 deletions docs/index.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,6 +14,23 @@ SpatialData is a data framework that comprises a FAIR storage format and a colle

Please see our publication {cite}`marconatoSpatialDataOpenUniversal2024` for citation and to learn more.

:::{note}
With dask >= 2025.2.0, users can get an error as described in [#1077](https://github.com/scverse/spatialdata/issues/1064). While we tried implementing fixes in SpatialData, it can be that
users perform operations on the `Points` data themselves and get this error. In order to prevent it, users can use a context manager we created.

```python
from spatialdata import disable_dask_tune_optimization
import contextlib
...

with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
<your operation on points dask dataframe>
```

This will disable dask graph optimization if the dataframe has more than 1 partition and otherwise keep it enabled. This solves
the problem discussed in this [dask issue](https://github.com/dask/dask/issues/12193). We are looking into an upstream fix.
:::

[//]: # "numfocus-fiscal-sponsor-attribution"

spatialdata is part of the scverse® project ([website](https://scverse.org), [governance](https://scverse.org/about/roles)) and is fiscally sponsored by [NumFOCUS](https://numfocus.org/).
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,7 +26,7 @@ dependencies = [
"annsel>=0.1.2",
"click",
"dask-image",
"dask>=2025.2.0,<2026.1.2",
"dask>=2025.12.0,<2026.1.2",
"distributed<2026.1.2",
"datashader",
"fsspec[s3,http]",
Expand Down
3 changes: 2 additions & 1 deletion src/spatialdata/__init__.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,6 +9,7 @@
"transformations",
"datasets",
"dataloader",
"disable_dask_tune_optimization",
"concatenate",
"rasterize",
"rasterize_bins",
Expand DownExpand Up@@ -72,5 +73,5 @@
from spatialdata._io._utils import get_dask_backing_files
from spatialdata._io.format import SpatialDataFormatType
from spatialdata._io.io_zarr import read_zarr
from spatialdata._utils import get_pyramid_levels, unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, get_pyramid_levels, unpad_raster
from spatialdata.config import settings
13 changes: 11 additions & 2 deletions src/spatialdata/_core/operations/transform.py
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
from __future__ import annotations

import contextlib
import itertools
import warnings
from functools import singledispatch
Expand All@@ -17,6 +18,7 @@

from spatialdata._core.spatialdata import SpatialData
from spatialdata._types import ArrayLike
from spatialdata._utils import disable_dask_tune_optimization
from spatialdata.models import SpatialElement, get_axes_names, get_model
from spatialdata.models._utils import DEFAULT_COORDINATE_SYSTEM, get_channel_names
from spatialdata.transformations._utils import _get_scale, compute_coordinates, scale_radii
Expand DownExpand Up@@ -439,8 +441,15 @@ def _(
)
axes = get_axes_names(data)
arrays = []
for ax in axes:
arrays.append(data[ax].to_dask_array(lengths=True).reshape(-1, 1))

# Workaround to prevent partition collaps and missing dependency problem for now.
with disable_dask_tune_optimization() if data.npartitions > 1 else contextlib.nullcontext():
for ax in axes:
# TODO We have to pass on the lengths explicitly as automatic determination with dask graph optimization
# leads to collaps of the partitions. However this causes a missing dependency problem, which for now is
# prevented by setting the optimization to False when performing this operation.
arrays.append(data[ax].to_dask_array(lengths=[len(part) for part in data.partitions]).reshape(-1, 1))

xdata = DataArray(da.concatenate(arrays, axis=1), coords={"points": range(len(data)), "dim": list(axes)})
xtransformed = transformation._transform_coordinates(xdata)
transformed = data.drop(columns=list(axes)).copy()
Expand Down
13 changes: 13 additions & 0 deletions src/spatialdata/_utils.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -2,13 +2,15 @@
import re
import warnings
from collections.abc import Callable, Generator
from contextlib import contextmanager
from itertools import islice
from typing import Any, TypeVar

import numpy as np
import pandas as pd
from anndata import AnnData
from dask import array as da
from dask import config
from dask.array import Array as DaskArray
from xarray import DataArray, Dataset, DataTree

Expand All@@ -20,6 +22,17 @@
RT = TypeVar("RT")


@contextmanager
def disable_dask_tune_optimization() -> Generator[None, None, None]:
"""Prevent dask graph optimization when performing operations on dask dataframes with npartition > 1."""
old_setting = config.config["optimization"]["tune"]["active"]
config.set({"optimization.tune.active": False})
try:
yield
finally:
config.set({"optimization.tune.active": old_setting})


def _parse_list_into_array(array: list[Number] | ArrayLike) -> ArrayLike:
if isinstance(array, list):
array = np.array(array)
Expand Down
42 changes: 41 additions & 1 deletion tests/core/operations/test_transform.py
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,18 @@
import contextlib
import math
import tempfile
from pathlib import Path

import numpy as np
import pytest
from dask import config
from geopandas.testing import geom_almost_equals
from xarray import DataArray, DataTree

from spatialdata import transform
from spatialdata._core.data_extent import are_extents_equal, get_extent
from spatialdata._core.spatialdata import SpatialData
from spatialdata._utils import unpad_raster
from spatialdata._utils import disable_dask_tune_optimization, unpad_raster
from spatialdata.models import Image2DModel, PointsModel, ShapesModel, get_axes_names
from spatialdata.transformations.operations import (
align_elements_using_landmarks,
Expand DownExpand Up@@ -586,6 +588,44 @@ def test_transform_elements_and_entire_spatial_data_object(full_sdata: SpatialDa
_ = full_sdata.transform_to_coordinate_system("my_space", maintain_positioning=maintain_positioning)


def test_transform_points_with_multiple_partitions(full_sdata: SpatialData, tmp_path: str):
tmpdir = Path(tmp_path) / "tmp.zarr"
points_memory = full_sdata["points_0"].compute()
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)
assert points_memory.equals(full_sdata["points_0"].compute())

full_sdata.write(tmpdir)

full_sdata = SpatialData.read(tmpdir)

# This just needs to run without error
data = transform(full_sdata["points_0"], to_coordinate_system="global")

# test that data still can be computed
data.compute()


@pytest.mark.parametrize(
"tune,partition",
[
(True, None),
(False, 4),
],
)
def test_dask_tune_contextmanager(full_sdata: SpatialData, partition: int | None, tune: bool):
if partition:
full_sdata["points_0"] = PointsModel.parse(
full_sdata["points_0"].repartition(npartitions=4),
transformations={"global": get_transformation(full_sdata["points_0"])},
)

with disable_dask_tune_optimization() if full_sdata["points_0"].npartitions > 1 else contextlib.nullcontext():
assert config.config["optimization"]["tune"]["active"] is tune


@pytest.mark.parametrize("maintain_positioning", [True, False])
def test_transform_elements_and_entire_spatial_data_object_multi_hop(
full_sdata: SpatialData, maintain_positioning: bool
Expand Down