Uh oh!
There was an error while loading. Please reload this page.
test: document join scoping for a region absent from the query - #1195
Draft
jan-glx wants to merge 2 commits into
Draft
test: document join scoping for a region absent from the query#1195jan-glx wants to merge 2 commits into
jan-glx wants to merge 2 commits into
Conversation
Pins down current behavior for a table row whose region wasn't part of spatial_element_names, for both a real-but-unqueried element and one missing from the SpatialData object entirely (reachable e.g. via sdata.subset(..., filter_tables=False)). "left", "left_exclusive", "inner" and "right_exclusive" all scope themselves to the queried elements only; "right" always returns the table unfiltered. So "right_exclusive" isn't simply "right minus inner" here, and the two unqueried-region scenarios are currently indistinguishable to join_spatialelement_table. No behavior change; this documents the status quo ahead of a design decision on which of these two behaviors (if either) is intended.
for more information, see https://pre-commit.ci
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1195 +/- ##
=======================================
Coverage 91.89% 91.89% =======================================
Files 53 53 Lines 7942 7942 =======================================
Hits 7298 7298 Misses 644 644 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins down current behavior for a table row whose region wasn't part of spatial_element_names, for both a real-but-unqueried element and one missing from the SpatialData object entirely (reachable e.g. via sdata.subset(..., filter_tables=False)). "left", "left_exclusive", "inner" and "right_exclusive" all scope themselves to the queried elements only; "right" always returns the table unfiltered. So "right_exclusive" isn't simply "right minus inner" here, and the two unqueried-region scenarios are currently indistinguishable to join_spatialelement_table.
No behavior change; this documents the status quo ahead of a design decision on which of these two behaviors (if either) is intended.