Uh oh!
There was an error while loading. Please reload this page.
test: drop the "c" region case from the interleaved-regions join fixture - #1196
Merged
jan-glx merged 1 commit intoAug 28, 2026
Merged
Conversation
Region "c" was added to _make_interleaved_regions_sdata with no matching spatial element in the SpatialData object at all, and right_exclusive was marked xfail(strict=True) for not surfacing its row as excluded. That state (a table declaring a region absent from the SpatialData object) already triggers a UserWarning at SpatialData construction/subset time (validate_table_in_spatialdata), and whether join_spatialelement_table should be expected to handle it, and how, given the "b3" case is still correctly handled and the mostly working state of the codebase, is a design question, not a clear-cut bug. Dropping the case and the xfail here; a follow-up documents the actual behavior instead.
jan-glx
marked this pull request as ready for review
August 28, 2026 15:48
jan-glx
enabled auto-merge (rebase)
August 28, 2026 15:49
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1196 +/- ##
=======================================
Coverage 91.89% 91.89% =======================================
Files 53 53 Lines 7942 7942 =======================================
Hits 7298 7298 Misses 644 644 🚀 New features to boost your workflow:
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts 8def24d and partially reverts d6eb989 in favor of b8077fb