Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Added subset API; fix behavior with zero-len table by LucaMarconato · Pull Request #426 · scverse/spatialdata · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -16,6 +16,8 @@ and this project adheres to [Semantic Versioning][].

### Added

- added SpatialData.subset() API

### Fixed

#### Minor
Expand Down
6 changes: 6 additions & 0 deletions src/spatialdata/_core/query/spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -266,6 +266,8 @@ def _(
new_elements[element_type] = queried_elements

table = _filter_table_by_elements(sdata.table, new_elements) if filter_table else sdata.table
if len(table) == 0:
table = None
return SpatialData(**new_elements, table=table)


Expand DownExpand Up@@ -641,6 +643,8 @@ def _polygon_query(

if filter_table and sdata.table is not None:
table = _filter_table_by_elements(sdata.table, {"shapes": new_shapes, "points": new_points})
if table is not None and len(table) == 0:
table = None
else:
table = sdata.table
return SpatialData(shapes=new_shapes, points=new_points, images=new_images, table=table)
Expand DownExpand Up@@ -749,5 +753,7 @@ def polygon_query(
geodataframes[k] = vv

table = _filter_table_by_elements(sdata.table, {"shapes": geodataframes}) if filter_table else sdata.table
if len(table) == 0:
table = None

return SpatialData(shapes=geodataframes, table=table)
27 changes: 27 additions & 0 deletions src/spatialdata/_core/spatialdata.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -1124,6 +1124,33 @@ def init_from_elements(cls, elements: dict[str, SpatialElement], table: AnnData
elements_dict.setdefault(element_type, {})[name] = element
return cls(**elements_dict, table=table)

def subset(self, element_names: list[str], filter_table: bool = True) -> SpatialData:
"""
Subset the SpatialData object.

Parameters
----------
element_names
The names of the element_names to subset.
filter_table
If True (default), the table is filtered to only contain rows that are annotating regions
contained within the element_names.

Returns
-------
The subsetted SpatialData object.
"""
from spatialdata._core.query.relational_query import _filter_table_by_elements

elements_dict: dict[str, SpatialElement] = {}
for element_type, element_name, element in self._gen_elements():
if element_name in element_names:
elements_dict.setdefault(element_type, {})[element_name] = element
table = _filter_table_by_elements(self.table, elements_dict=elements_dict) if filter_table else self.table
if len(table) == 0:
table = None
return SpatialData(**elements_dict, table=table)

def __getitem__(self, item: str) -> SpatialElement:
"""
Return the element with the given name.
Expand Down
30 changes: 28 additions & 2 deletions tests/core/operations/test_spatialdata_operations.py
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
from __future__ import annotations

import numpy as np
import pytest
from anndata import AnnData
Expand DownExpand Up@@ -123,8 +125,8 @@ def _assert_elements_left_to_right_seem_identical(sdata0: SpatialData, sdata1: S
raise TypeError(f"Unsupported type {type(element)}")


def _assert_tables_seem_identical(table0: AnnData, table1: AnnData) -> None:
assert table0.shape == table1.shape
def _assert_tables_seem_identical(table0: AnnData | None, table1: AnnData | None) -> None:
assert table0 is None and table1 is None or table0.shape == table1.shape


def _assert_spatialdata_objects_seem_identical(sdata0: SpatialData, sdata1: SpatialData) -> None:
Expand DownExpand Up@@ -360,3 +362,27 @@ def test_init_from_elements(full_sdata: SpatialData) -> None:
sdata = SpatialData.init_from_elements(all_elements, table=full_sdata.table)
for element_type in ["images", "labels", "points", "shapes"]:
assert set(getattr(sdata, element_type).keys()) == set(getattr(full_sdata, element_type).keys())


def test_subset(full_sdata: SpatialData) -> None:
element_names = ["image2d", "labels2d", "points_0", "circles", "poly"]
subset0 = full_sdata.subset(element_names)
unique_names = set()
for _, k, _ in subset0._gen_elements():
unique_names.add(k)
assert "image3d_xarray" in full_sdata.images
assert unique_names == set(element_names)
assert subset0.table is None

adata = AnnData(
shape=(10, 0),
obs={"region": ["circles"] * 5 + ["poly"] * 5, "instance_id": [0, 1, 2, 3, 4, "a", "b", "c", "d", "e"]},
)
del full_sdata.table
full_sdata.table = TableModel.parse(
adata, region=["circles", "poly"], region_key="region", instance_key="instance_id"
)
subset1 = full_sdata.subset(["poly"])
assert subset1.table is not None
assert len(subset1.table) == 5
assert subset1.table.obs["region"].unique().tolist() == ["poly"]
2 changes: 1 addition & 1 deletion tests/core/query/test_spatial_query.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -364,7 +364,7 @@ def test_polygon_query_points(sdata_query_aggregation):
queried = polygon_query(sdata, polygons=polygon, target_coordinate_system="global", shapes=False, points=True)
points = queried["points"].compute()
assert len(points) == 6
assert len(queried.table) == 0
assert queried.table is None

# TODO: the case of querying points with multiple polygons is not currently implemented

Expand Down