Uh oh!
There was an error while loading. Please reload this page.
feat: make ResourceReference hashable - #1668
Merged
bcantoni merged 6 commits intoNov 10, 2025
Merged
Conversation
jorwoodsforce-pushed
the
jorwoods/hashing_reference
branch
from
October 17, 2025 20:28
3890990 to
a7310eeCompareClosestableau#1666 This allows `ResourceReference` to be used as a key in dicts, as well as added to sets by making it hashable. Also adds a `to_reference` method, while leaving the the `as_reference` static method in place untouched.
jorwoodsforce-pushed
the
jorwoods/hashing_reference
branch
from
October 17, 2025 20:41
a7310ee to
c39ba83CompareThere was a problem hiding this comment.
Pull Request Overview
This pull request adds type safety improvements and a new to_reference() method to model classes. The changes include:
- Adding type hints to
ResourceReferenceclass methods and properties - Implementing
__hash__()method forResourceReferenceto make it hashable - Adding
to_reference()instance methods toUserItem,GroupItem, andGroupSetItemthat convert instances toResourceReferenceobjects - Adding null safety checks in the permissions request factory to validate grantee IDs
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tableauserverclient/models/reference_item.py | Added type hints and __hash__() method to ResourceReference class |
| tableauserverclient/models/user_item.py | Added to_reference() method with null check for converting UserItem to ResourceReference |
| tableauserverclient/models/group_item.py | Added to_reference() method with null check for converting GroupItem to ResourceReference |
| tableauserverclient/models/groupset_item.py | Added to_reference() method with null check for converting GroupSetItem to ResourceReference |
| tableauserverclient/server/request_factory.py | Added validation to ensure grantee has an ID before adding to XML element |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
jorwoodsforce-pushed
the
jorwoods/hashing_reference
branch
from
October 29, 2025 13:47
3ca1445 to
9e697e4Comparejorwoods
commented
Oct 30, 2025
ContributorAuthor
bcantoni
approved these changes
Nov 5, 2025
bcantoni
commented
Nov 5, 2025
Contributor
@jorwoods yea you can ignore that license compliance thing. It's not a blocking check luckily. |
Uh oh!
There was an error while loading. Please reload this page.
jacalata added a commit
that referenced
this pull request
Feb 2, 2026
* feat: New APIs: Update multiple connections in a single workbook/datasource (#1638) * feat: enable toggling attribute capture for a site (#1619) * feat: support OIDC endpoints (#1630) * feat: add WebAuthoringForFlows capability to Permission class (#1642) * feat: support collections in favorites (#1647) * feat: Add UAT (unified access token) support to JWT login (#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (#1617) (#1669) * feat: make refresh consistent between endpoints (#1665) * feat: make ResourceReference hashable (#1668) Closes#1666 * feat: delete view (#1712) * feat: batch create schedule (#1714) * feat: users csv import (#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (#1670) * feat: implement #816: project.get_by_id (#1736) * fix: put special fields first (#1622) Closes#1620 * fix: virtual connections username (#1628) Closes#1626 * fix: add contentType to tags batch actions (#1643) * fix: datasource owner/project missing parsing (#1700) * fix: datasource description update and publish (#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (#1730) * fix: handle parameters for view filters (#1633) * fix: handle parameters for view filters Closes#1632
vchavatapalli pushed a commit
to vchavatapalli/server-client-python
that referenced
this pull request
May 5, 2026
* feat: New APIs: Update multiple connections in a single workbook/datasource (tableau#1638) * feat: enable toggling attribute capture for a site (tableau#1619) * feat: support OIDC endpoints (tableau#1630) * feat: add WebAuthoringForFlows capability to Permission class (tableau#1642) * feat: support collections in favorites (tableau#1647) * feat: Add UAT (unified access token) support to JWT login (tableau#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (tableau#1617) (tableau#1669) * feat: make refresh consistent between endpoints (tableau#1665) * feat: make ResourceReference hashable (tableau#1668) Closestableau#1666 * feat: delete view (tableau#1712) * feat: batch create schedule (tableau#1714) * feat: users csv import (tableau#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (tableau#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (tableau#1670) * feat: implement tableau#816: project.get_by_id (tableau#1736) * fix: put special fields first (tableau#1622) Closestableau#1620 * fix: virtual connections username (tableau#1628) Closestableau#1626 * fix: add contentType to tags batch actions (tableau#1643) * fix: datasource owner/project missing parsing (tableau#1700) * fix: datasource description update and publish (tableau#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (tableau#1730) * fix: handle parameters for view filters (tableau#1633) * fix: handle parameters for view filters Closestableau#1632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1666
This allows
ResourceReferenceto be used as a key in dicts, as well as added to sets by making it hashable. Also adds ato_referencemethod, while leaving the theas_referencestatic method in place untouched.