Uh oh!
There was an error while loading. Please reload this page.
fix: add workbook and view setter for custom view - #1730
Merged
bcantoni merged 2 commits intoJan 6, 2026
Conversation
Closestableau#1729 Add setter methods for workbook and view properties.
jorwoodsforce-pushed
the
jorwoods/custom_view_set_wb
branch
from
December 29, 2025 14:48
9a1de1e to
eb2df3fComparebcantoni
commented
Jan 6, 2026
Contributor
@jorwoods this looks great. Should we also consider updating test_custom_view.py to replace those direct access _owner and _workbook with the new way? (I'm not sure that's super valuable though because we still have the direct access needed for |
jorwoods
commented
Jan 6, 2026
ContributorAuthor
@bcantoni Makes sense to me to verify that the getters and setters work. I'll make the change. |
bcantoni
approved these changes
Jan 6, 2026
Uh oh!
There was an error while loading. Please reload this page.
jacalata added a commit
that referenced
this pull request
Feb 2, 2026
* feat: New APIs: Update multiple connections in a single workbook/datasource (#1638) * feat: enable toggling attribute capture for a site (#1619) * feat: support OIDC endpoints (#1630) * feat: add WebAuthoringForFlows capability to Permission class (#1642) * feat: support collections in favorites (#1647) * feat: Add UAT (unified access token) support to JWT login (#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (#1617) (#1669) * feat: make refresh consistent between endpoints (#1665) * feat: make ResourceReference hashable (#1668) Closes#1666 * feat: delete view (#1712) * feat: batch create schedule (#1714) * feat: users csv import (#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (#1670) * feat: implement #816: project.get_by_id (#1736) * fix: put special fields first (#1622) Closes#1620 * fix: virtual connections username (#1628) Closes#1626 * fix: add contentType to tags batch actions (#1643) * fix: datasource owner/project missing parsing (#1700) * fix: datasource description update and publish (#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (#1730) * fix: handle parameters for view filters (#1633) * fix: handle parameters for view filters Closes#1632
jacalata pushed a commit
that referenced
this pull request
Feb 3, 2026
* fix: add workbook and view setter for custom view * chore: use workbook setter in tests Closes#1729 --------- Co-authored-by: Jordan Woods <13803242+jorwoods@users.noreply.github.com>
jacalata pushed a commit
that referenced
this pull request
Feb 3, 2026
* fix: add workbook and view setter for custom view * chore: use workbook setter in tests Closes#1729 --------- Co-authored-by: Jordan Woods <13803242+jorwoods@users.noreply.github.com>
vchavatapalli pushed a commit
to vchavatapalli/server-client-python
that referenced
this pull request
May 5, 2026
* feat: New APIs: Update multiple connections in a single workbook/datasource (tableau#1638) * feat: enable toggling attribute capture for a site (tableau#1619) * feat: support OIDC endpoints (tableau#1630) * feat: add WebAuthoringForFlows capability to Permission class (tableau#1642) * feat: support collections in favorites (tableau#1647) * feat: Add UAT (unified access token) support to JWT login (tableau#1671) * feat: Update permissions_item.py --added ExtractRefresh attribute (tableau#1617) (tableau#1669) * feat: make refresh consistent between endpoints (tableau#1665) * feat: make ResourceReference hashable (tableau#1668) Closestableau#1666 * feat: delete view (tableau#1712) * feat: batch create schedule (tableau#1714) * feat: users csv import (tableau#1409) * feat: implement users bulk_remove * feat: enable idp_configuration_id in bulk_add * feat: support extensions api (tableau#1672) * feat: Add support for receiving "Customized Monthly" schedule intervals (tableau#1670) * feat: implement tableau#816: project.get_by_id (tableau#1736) * fix: put special fields first (tableau#1622) Closestableau#1620 * fix: virtual connections username (tableau#1628) Closestableau#1626 * fix: add contentType to tags batch actions (tableau#1643) * fix: datasource owner/project missing parsing (tableau#1700) * fix: datasource description update and publish (tableau#1682) * fix: windows decoding error * fix: assert on warning instead of ignore * fix: add workbook and view setter for custom view (tableau#1730) * fix: handle parameters for view filters (tableau#1633) * fix: handle parameters for view filters Closestableau#1632
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#1729
Add setter methods for workbook and view properties.