Skip to content

docs: note that closing keywords do not fire on a develop merge - #113

Merged
LukasWodka merged 1 commit into
developfrom
docs/pr-template-develop-caveat
Jul 31, 2026
Merged

docs: note that closing keywords do not fire on a develop merge#113
LukasWodka merged 1 commit into
developfrom
docs/pr-template-develop-caveat

Conversation

@LukasWodka

@LukasWodkaLukasWodka commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Precondition for backend#1373.

client and cli both carry this caveat in their own PR templates. It is not repo-specific — every repo targets develop, and GitHub only honours closing keywords when a PR merges into the default branch. So Closes #123 on a develop-targeted PR silently does nothing until the change is promoted to main/master.

#1373 proposes deleting the per-repo templates so the org one applies automatically. This is one of exactly two things those templates knew that the shared one did not — lifting it up first means the deletions lose nothing.


Note

Low Risk
Documentation-only change to the PR template with no runtime or security impact.

Overview
Updates the shared Related section comment in .github/pull_request_template.md so contributors know Closes / Fixes keywords only work when merging into the default branch, not when PRs target develop.

This aligns the org template with caveats already in per-repo templates and supports consolidating templates without losing that guidance.

Reviewed by Cursor Bugbot for commit edec69f. Bugbot is set up for automated code reviews on this repo. Configure here.

client and cli both carry this caveat in their own PR templates, and it is not
repo-specific -- every repo targets develop, and GitHub only honours closing
keywords when a PR merges into the DEFAULT branch. So `Closes#123` on a
develop-targeted PR silently does nothing until the change reaches main/master.
Lifting it into the org template is a precondition for backend#1373: the plan
there is to delete the per-repo templates so the org one applies, and this is
one of the two things those templates knew that the shared one did not.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@LukasWodkaLukasWodka self-assigned this Jul 31, 2026
@LukasWodka

Copy link
Copy Markdown
ContributorAuthor

👋 Heads-up — Code review queue is at 41 / 30

Above the WIP limit. The team convention is to review existing PRs before opening new work.

Open PRs currently in Code review (oldest first):

Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@LukasWodka