Uh oh!
There was an error while loading. Please reload this page.
docs: note that closing keywords do not fire on a develop merge - #113
Merged
Conversation
client and cli both carry this caveat in their own PR templates, and it is not repo-specific -- every repo targets develop, and GitHub only honours closing keywords when a PR merges into the DEFAULT branch. So `Closes#123` on a develop-targeted PR silently does nothing until the change reaches main/master. Lifting it into the org template is a precondition for backend#1373: the plan there is to delete the per-repo templates so the org one applies, and this is one of the two things those templates knew that the shared one did not. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
LukasWodka
commented
Jul 31, 2026
ContributorAuthor
👋 Heads-up — Code review queue is at 41 / 30 Above the WIP limit. The team convention is to review existing PRs before opening new work. Open PRs currently in Code review (oldest first):
Pull from review before opening new work. (This is a nudge from the kanban WIP check, not a block.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Precondition for backend#1373.
clientandcliboth carry this caveat in their own PR templates. It is not repo-specific — every repo targetsdevelop, and GitHub only honours closing keywords when a PR merges into the default branch. SoCloses #123on a develop-targeted PR silently does nothing until the change is promoted tomain/master.#1373 proposes deleting the per-repo templates so the org one applies automatically. This is one of exactly two things those templates knew that the shared one did not — lifting it up first means the deletions lose nothing.
Note
Low Risk
Documentation-only change to the PR template with no runtime or security impact.
Overview
Updates the shared Related section comment in
.github/pull_request_template.mdso contributors knowCloses/Fixeskeywords only work when merging into the default branch, not when PRs targetdevelop.This aligns the org template with caveats already in per-repo templates and supports consolidating templates without losing that guidance.
Reviewed by Cursor Bugbot for commit edec69f. Bugbot is set up for automated code reviews on this repo. Configure here.