Uh oh!
There was an error while loading. Please reload this page.
fix(fr-gate): release-train promotion PRs are transparent plumbing - #94
Merged
Merged
Conversation
Without this, the staging->prod hop gates the PREVIOUS promotion PRs themselves: a release-train/to-staging merge is that PR's merge_commit_sha, so Pass 1 pulls e.g. averaging-service#211 / frontend-app#709 into the checked set, where they sit at 'FR on staging' forever (nobody FRs plumbing) and block the prod promotion. Worse, commits/pulls lists the promotion PR for every commit it carried, so Pass 2 could attribute a direct push to the promotion PR and launder it into 'covered'. Fix: filter head release-train/* out of attribution in both passes. The promotion merge neither vouches for its range nor appears as a gated item; its cargo attributes individually (feature merges in Pass 1, squash commits in Pass 2). A commit whose only merged PR is a promotion PR is a direct push that rode the train -- it stays unattributed and fails closed (D27-L1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On the staging→prod hop, the gate pulls the previous dev→staging promotion PRs themselves into the checked set (their merges are those PRs'
merge_commit_sha). Plumbing PRs sit at FR on staging forever — nobody functional-reviews plumbing — so they would block every prod promotion (live today: averaging-service#211, frontend-app#709). Pass 2 has the inverse hole:commits/pullslists the promotion PR for every commit it carried, so a direct push could be attributed to the promotion PR and ride to prod laundered.Fix
Filter
head: release-train/*out of attribution in both passes — promotion PRs never appear as gated items and never vouch for their range. Cargo attributes individually (feature merges in Pass 1, squash commits in Pass 2). A commit whose only merged PR is a promotion PR is a direct push that rode the train → stays unattributed → fails closed (D27-L1 preserved).Test plan
actionlintcleanmain: re-run client-runtime docs(inventory): the contract denied an action-pins gate that is armed (backend#1668) #215's gate (staging hop, must stay green)🤖 Generated with Claude Code
Note
Medium Risk
Changes promotion-blocking logic in a required merge gate; mis-filtering could fail open or closed, but scope is limited to jq filters and comments in one workflow.
Overview
FR gate commit→PR discovery no longer treats release-train promotion PRs (
headrelease-train/*) as items to gate or as proof that their range was reviewed.In Pass 1 (merge commits), promotion PRs are dropped from attribution and do not enter the merge “vouch” set, so only real feature/cargo PR merges count. In Pass 2 (individual commits), the same filter stops every carried commit from being credited to the promotion PR; commits whose only merged PR is a promotion PR stay unattributed and still fail closed.
Header comments now document API-based discovery and this transparent-plumbing behavior instead of subject-line PR parsing.
Reviewed by Cursor Bugbot for commit 83c40b0. Bugbot is set up for automated code reviews on this repo. Configure here.