Uh oh!
There was an error while loading. Please reload this page.
[nest] Use AST-based CommonJS import rewriting - #2080
Merged
Conversation
Signed-off-by: yao <zhangyaoruo@outlook.com>
SWC's `module.span.start` keeps the leading shebang line inside the module span but excludes leading line/block comments and a BOM. The previous `getLeadingSyntaxByteOffset` skipped the shebang, which made `module.span.start - leadingOffset - 1` shift every subsequent byte→string mapping. A steps bundle that starts with `#!/usr/bin/env node` would either throw `Unable to map SWC byte position X to a string index` or silently corrupt the rewrite. - Rename `getLeadingSyntaxByteOffset` → `getLeadingCommentByteOffset` and drop the shebang branch. - Document the invariant tying SWC's 1-based global byte counter to source-relative offsets so a future change to SWC's span behavior doesn't silently break the rewriter. - Add test coverage for shebang, shebang+comment, BOM, CRLF, dynamic imports, empty named imports, `default as`, mixed default+namespace, duplicate imports of the same module, and template-literal substrings. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
🦋 Changeset detectedLatest commit: 7ae4af5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 16 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 25 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 50 sequential data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 10 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 25 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express workflow with 50 concurrent data payload steps (10KB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express Stream Benchmarks(includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express stream pipeline with 5 transform steps (1MB)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express 10 parallel streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express fan-out fan-in 10 streams (1MB each)💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
🧪 E2E Test Results✅ All tests passed Summary
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
✅ 📋 Other
|
VaguelySerious
marked this pull request as ready for review
May 22, 2026 11:35
karthikscale3
approved these changes
Jun 5, 2026
karthikscale3
left a comment
Contributor
There was a problem hiding this comment.
Reviewed for blockers and regressions. No blocking code issues found.
I checked the AST rewrite against the touched Nest rewriter paths, especially SWC byte-span mapping and generated CommonJS semantics. The added coverage for shebang, BOM, CRLF, non-ASCII content, default/namespace imports, side-effect imports, and dynamic-import non-rewrites looks solid.
Verification from a temp checkout of the PR:
- pnpm --filter @workflow/nest test: passed, 34 tests
- tsc -p packages/nest/tsconfig.json --noEmit: passed
CI note: the overall commit status is green and E2E passed. The full check-run list still shows 2 failed and 4 cancelled benchmark jobs, which I do not see as tied to this diff.
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
that referenced
this pull request
Jun 5, 2026
Signed-off-by: yao <zhangyaoruo@outlook.com> Co-authored-by: yao <zhangyaoruo@outlook.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com>
Contributor
Backport PR opened against |
TooTallNate pushed a commit
that referenced
this pull request
Jun 5, 2026
Signed-off-by: yao <zhangyaoruo@outlook.com> Signed-off-by: Peter Wielander <mittgfu@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: yao <zhangyaoruo@outlook.com>
This was referenced Jun 5, 2026
Merged
pranaygp added a commit
that referenced
this pull request
Jun 11, 2026
…-attributes-client * origin/main: (32 commits) feat(core): add optional namespace for queue topic prefix (#2305) [web-shared] Show precise durations in the new trace viewer (#2335) Validate unique workflow step IDs at build time (#2018) Move run attributes into their own detail card (#2327) [core] Forward-port stream reconnect to getReadable level (#2318) [docs] Add "Step executed multiple times" error page (#2310) Fix flickering on the detail panel when navigating the trace viewer (#2325) Version Packages (beta) (#2254) Patch vulnerable package dependencies (#2301) Deprecate DurableAgent and update it with WorkflowAgent in v5 docs (#2285) [codex] Fix partial world-local exclusive writes (#2296) [world-vercel] Validate ref resolve responses before use (#2035) fix: bump devalue to 5.8.1 (#2292) Handle lazy stream key request failures (#2257) fix(docs): declare Nitro auto-import globals for code samples (#2290) [core] Preserve event-log order in hook-vs-sleep replay races (#2171) (#2185) docs: add nitro changelog (#2232) fix(next): always apply turbopack content condition regardless of builder mode (#2253) Update @vercel/queue from 0.2.1 to 0.3.0 (#2255) [nest] Use AST-based CommonJS import rewriting (#2080) ... # Conflicts: # packages/world-local/src/storage/events-storage.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: yao <zhangyaoruo@outlook.com>Closes#2001. Picks up @boomyao's AST-based CJS import rewriter from #2001 and addresses review feedback on top:
module.span.startkeeps a leading shebang line inside the module span but excludes leading line/block comments and a BOM. The previousgetLeadingSyntaxByteOffsetskipped the shebang, which mademodule.span.start - leadingOffset - 1shift every byte→string mapping by the shebang's length. A steps bundle starting with#!/usr/bin/env nodewould either throwUnable to map SWC byte position X to a string indexor silently corrupt the rewrite. Renamed togetLeadingCommentByteOffsetand dropped the shebang branch.import("..."), empty named imports,default as, mixed default+namespace, two imports of the same module, and an import-shaped substring inside a template literal.