Uh oh!
There was an error while loading. Please reload this page.
fix(plan): serve runner getEnv from unfiltered env context - #447
Merged
Conversation
MemberAuthor
This was referenced Jun 13, 2026
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 11:11
7f74f46 to
29db327Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 14:22
29db327 to
e9111bdComparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 14:27
e9111bd to
97761baComparewan9chiforce-pushed
the
infra-get-env-ipc
branch
2 times, most recently
from
June 13, 2026 14:36
9d3eeb1 to
1d8eec4Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 15:58
4b74a2c to
c45b304Comparewan9chi
marked this pull request as ready for review
June 13, 2026 15:59
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:c45b304dc4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 16:03
b96d1bd to
b3d0921Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 16:08
b3d0921 to
83684b7Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 16:09
83684b7 to
3dcd916Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 17:16
3dcd916 to
eac9b11Comparewan9chi
changed the base branch from
graphite-base/447
to
infra-spawn-envs-renameJune 13, 2026 17:16
wan9chi
changed the base branch from
infra-spawn-envs-rename
to
graphite-base/447June 13, 2026 17:17
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 17:22
eac9b11 to
0a8737dComparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
3 times, most recently
from
June 13, 2026 17:43
7bf34a6 to
feb640cCompareMotivation: Runner-served getEnv values need to match the command context that planning and execution use, including command-prefix envs and enclosing nested vp run prefix envs. Serving only the filtered child env can hide undeclared prefix values from tools. Scope: Build on the spawn_envs naming cleanup by storing the unfiltered command env context on CacheMetadata for cached executions, then serve runner getEnv from that context. This keeps SpawnCommand focused on process-spawn data and intentionally does not add cache fingerprinting for getEnv reads. Verification: - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_sees_command_prefix_env -- --ignored - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_sees_intermediate_prefix_envs -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_sees_command_prefix_env -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_sees_intermediate_prefix_envs -- --ignored - cargo check -p vite_task_plan -p vite_task -p vite_task_bin - cargo test -p vite_task_plan envs::tests - cargo test -p vite_task_plan --test plan_snapshots
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 14, 2026 02:21
feb640c to
9a6d7efCompareMemberAuthor
Uh oh!
There was an error while loading. Please reload this page.
wan9chi added a commit
that referenced
this pull request
Jun 14, 2026
Motivation: Revert the accidental merge of #448 so the tracked getEnv fingerprinting change can return as a normal reviewed PR instead of being landed out of order. Scope: This is a mechanical revert of the #448 squash commit (`2055bb0c`). It removes the tracked getEnv fingerprinting implementation and e2e coverage that #448 introduced, returning `main` to the #447 state. Verification: - CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Runner-served
getEnvvalues need to match the command context that planning and execution use, including command-prefix envs and enclosing nestedvp runprefix envs. Serving only the cache-filtered child env hides undeclared prefix values from runner-aware tools.Scope
Build on the
spawn_envsnaming cleanup by storing the unfiltered command env context onCacheMetadatafor cached executions, then serve runnergetEnvfrom that context.SpawnCommand::spawn_envsremains focused on the actual child process environment.This PR intentionally does not add cache fingerprinting for runner-served env reads. That is handled by the next PR in the stack. The e2e fixture now uses one generic
fetch_env.mjs <NAME> [...]helper and compares runner-served values withprocess.envfor undeclared envs, command-prefix envs, and nested prefix envs.Verification
cargo test -p vite_task_bin --test e2e_snapshots fetch_env -- --ignored