Uh oh!
There was an error while loading. Please reload this page.
feat(cache): fingerprint tracked getEnv reads - #448
Merged
Conversation
MemberAuthor
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 13, 2026
wan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 11:11
5e3b5ec to
51a8c0cComparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 14:22
29db327 to
e9111bdComparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
2 times, most recently
from
June 13, 2026 14:27
ce0d262 to
93cfb02Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 14:36
97761ba to
4b74a2cComparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 14:37
93cfb02 to
b77c960Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 15:58
4b74a2c to
c45b304Comparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 15:58
b77c960 to
aef9617Comparewan9chi
marked this pull request as ready for review
June 13, 2026 15:59
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 16:01
c45b304 to
b96d1bdComparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 16:01
aef9617 to
fee0f27Comparewan9chiforce-pushed
the
infra-get-env-prefix-context
branch
from
June 13, 2026 16:03
b96d1bd to
b3d0921Comparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 16:03
fee0f27 to
67b6aa2CompareThere was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:aef96174a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if fingerprinted.contains_key(name_str) { | ||
| return None; | ||
| } | ||
| let value = record.value.as_ref().and_then(|value| value.to_str().map(Str::from)); |
There was a problem hiding this comment.
When a runner-aware tool reads a secret such as GITHUB_TOKEN/NPM_TOKEN with the default tracked: true, this stores the raw value in the serialized PostRunFingerprint; on a later change SavedCacheMissReason::TrackedEnvChanged formats the same EnvMismatch, so old/new secret values can be persisted in the cache DB and emitted in the full task summary. Declared env fingerprinting hashes sensitive patterns in EnvFingerprints::resolve, but this new path bypasses that protection, so tracked envs should be hashed/redacted before storage/display.
Useful? React with 👍 / 👎.
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 16:09
83684b7 to
3dcd916Comparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 16:09
67b6aa2 to
f61eaacComparewan9chi
changed the base branch from
infra-get-env-prefix-context
to
graphite-base/448June 13, 2026 17:16
wan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 17:18
f61eaac to
8d340a9Comparewan9chi
changed the base branch from
graphite-base/448
to
infra-get-env-prefix-contextJune 13, 2026 17:18
wan9chiforce-pushed
the
infra-get-env-prefix-context
branch
2 times, most recently
from
June 13, 2026 17:22
0a8737d to
f19e16cComparewan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 17:22
8d340a9 to
be64c57Comparewan9chi
changed the base branch from
infra-get-env-prefix-context
to
graphite-base/448June 13, 2026 17:22
graphite-appBot
changed the base branch from
graphite-base/448
to
infra-get-env-prefix-contextJune 13, 2026 17:23
wan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 17:27
be64c57 to
136a98bComparewan9chi
changed the base branch from
infra-get-env-prefix-context
to
graphite-base/448June 13, 2026 17:43
wan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 13, 2026 17:44
136a98b to
7a67801Comparewan9chi
changed the base branch from
graphite-base/448
to
infra-get-env-prefix-contextJune 13, 2026 17:44
wan9chi
changed the base branch from
infra-get-env-prefix-context
to
graphite-base/448June 14, 2026 02:21
Motivation: Once tools can read env values from the runner, cached tasks must remember tracked getEnv reads or a later run can replay stale output after the env changes. Scope: Make the getEnv tracked option meaningful, record served single-env values in IPC reports, store tracked getEnv values in the post-run fingerprint, validate them during cache lookup, and render env-specific cache miss messages. This PR intentionally does not implement getEnvs or env glob match-set tracking. Verification: - cargo test -p vite_task_server --test integration - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored - UPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored
wan9chiforce-pushed
the
infra-get-env-fingerprint
branch
from
June 14, 2026 02:31
7a67801 to
08b48f2CompareMemberAuthor
Uh oh!
There was an error while loading. Please reload this page.
wan9chi added a commit
that referenced
this pull request
Jun 14, 2026
Motivation: Revert the accidental merge of #448 so the tracked getEnv fingerprinting change can return as a normal reviewed PR instead of being landed out of order. Scope: This is a mechanical revert of the #448 squash commit (`2055bb0c`). It removes the tracked getEnv fingerprinting implementation and e2e coverage that #448 introduced, returning `main` to the #447 state. Verification: - CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Once tools can read env values from the runner, cached tasks must remember tracked
getEnvreads. Otherwise a later run can replay stale output after a tracked env value changes.Scope
Make the
getEnvtracked option meaningful, record served single-env values in IPC reports, store tracked values in the post-run fingerprint, validate them during cache lookup, and render env-specific cache miss messages. This PR intentionally does not implementgetEnvsor env glob match-set tracking.Verification
cargo test -p vite_task_server --test integrationUPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignoredUPDATE_SNAPSHOTS=1 cargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignoredcargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracked_invalidates_on_change -- --ignoredcargo test -p vite_task_bin --test e2e_snapshots fetch_env_tracks_with_explicit_inputs -- --ignored