Uh oh!
There was an error while loading. Please reload this page.
test(e2e): verify real Vite env cache tracking - #451
Merged
Conversation
This was referenced Jun 13, 2026
MemberAuthor
This was referenced Jun 13, 2026
wan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 11:11
ecff178 to
8e2f29cComparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
2 times, most recently
from
June 13, 2026 14:23
2f128bc to
5a8cde0Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 14:23
8e2f29c to
d1d3cc1Comparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 14:27
5a8cde0 to
4990502Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 14:27
d1d3cc1 to
3fe4de9Comparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 14:38
4990502 to
9705c8fComparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 14:38
3fe4de9 to
f7bb71aComparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 15:58
9705c8f to
9477718Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 15:58
f7bb71a to
68b3368Comparewan9chi
marked this pull request as ready for review
June 13, 2026 15:59
wan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 16:01
9477718 to
a183557Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 16:02
68b3368 to
d7cf78eComparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 16:03
a183557 to
51c81c7Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 16:03
d7cf78e to
bf82ed3Comparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 16:10
51c81c7 to
2a05d2eComparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 16:10
bf82ed3 to
01c6d84Comparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 13, 2026 17:18
2a05d2e to
14b20deComparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 13, 2026 17:18
01c6d84 to
8d8b222Comparewan9chi
changed the base branch from
graphite-base/451
to
infra-get-envs-fingerprintJune 14, 2026 08:49
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/451June 14, 2026 09:14
wan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 14, 2026 09:15
88387e3 to
c6bbdf5Comparewan9chi
changed the base branch from
graphite-base/451
to
infra-get-env-tracked-optionJune 14, 2026 09:15
wan9chi
changed the base branch from
infra-get-env-tracked-option
to
graphite-base/451June 14, 2026 09:50
wan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 14, 2026 09:50
c6bbdf5 to
908a111Comparewan9chi
changed the base branch from
graphite-base/451
to
infra-get-env-tracked-optionJune 14, 2026 09:50
wan9chi
changed the base branch from
infra-get-env-tracked-option
to
graphite-base/451June 14, 2026 10:04
wan9chiforce-pushed
the
infra-vite-env-fixture
branch
from
June 14, 2026 10:05
908a111 to
dac897fComparewan9chi
changed the base branch from
graphite-base/451
to
infra-get-env-tracked-optionJune 14, 2026 10:05
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 10:09
b5e2a40 to
863801aComparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
2 times, most recently
from
June 14, 2026 10:12
77a4beb to
614b9e7Comparewan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:24
863801a to
6470102Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
2 times, most recently
from
June 14, 2026 12:25
0637bbd to
d9f08d7Comparewan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:39
6470102 to
d056c89Comparewan9chiforce-pushed
the
infra-vite-env-fixture
branch
2 times, most recently
from
June 14, 2026 12:50
8e3eb65 to
ac4f7ddCompareMotivation: The smaller IPC fixture proves runner env tracking in isolation, but reviewers also need confidence that the real Vite integration exercises getEnv for NODE_ENV and getEnvs for VITE_* prefixes. Scope: Add a minimal Vite build fixture and a local vtt grep-file helper used only to assert that changing VITE_MODE changes the emitted bundle. This PR does not introduce production APIs, playground changes, or output tracking behavior. Verification: - cargo test -p vite_task_bin --test e2e_snapshots vite_node_env_change_invalidates_cache -- --ignored - cargo test -p vite_task_bin --test e2e_snapshots vite_prefix_env_change_invalidates_cache -- --ignored
Co-authored-by: GPT-5 Codex <codex@openai.com>
MemberAuthor
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The focused IPC fixture proves runner env tracking in isolation, but reviewers also need confidence that the real Vite integration exercises
getEnvforNODE_ENVandgetEnvsforVITE_*prefixes. The prefix-env case should use a neutralVITE_*variable so it does not read like Vite mode orNODE_ENVbehavior.Scope
Add a minimal Vite build fixture and a local
vtt grep-filehelper. The fixture verifiesNODE_ENVchanges invalidate throughgetEnv, andVITE_CACHE_LABELchanges invalidate through Vite'sgetEnvs('VITE_*')path while changing the emitted bundle. The fixture keeps manual input exclusions so this PR remains about env tracking only; it intentionally does not introduce production APIs, playground changes, or output tracking behavior.