Uh oh!
There was an error while loading. Please reload this page.
feat(client): add tracked option for env IPC - #458
Merged
Conversation
This was referenced Jun 14, 2026
MemberAuthor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit:fb19a127bf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Uh oh!
There was an error while loading. Please reload this page.
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 09:14
fb19a12 to
6dab0e4Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 09:14
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 09:49
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 09:50
6dab0e4 to
1074c41Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 09:50
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 10:04
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 10:04
1074c41 to
b5e2a40Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 10:04
wan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
from
June 14, 2026 10:08
2a8601f to
860acd1Comparewan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 10:09
b5e2a40 to
863801aComparewan9chiforce-pushed
the
infra-get-envs-fingerprint
branch
2 times, most recently
from
June 14, 2026 12:24
782d20f to
d612fb4Comparewan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:24
863801a to
6470102Comparewan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 12:38
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:39
6470102 to
d056c89Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 12:39
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 12:49
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:50
d056c89 to
58fbea1Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 12:50
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 12:57
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 12:58
58fbea1 to
fc46389Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 12:58
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 12:59
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 13:00
fc46389 to
f27fb18Comparewan9chi
changed the base branch from
graphite-base/458
to
infra-get-envs-fingerprintJune 14, 2026 13:00
wan9chi
changed the base branch from
infra-get-envs-fingerprint
to
graphite-base/458June 14, 2026 13:04
wan9chiforce-pushed
the
infra-get-env-tracked-option
branch
from
June 14, 2026 13:04
f27fb18 to
90a513aComparewan9chiforce-pushed
the
infra-get-env-tracked-option
branch
2 times, most recently
from
June 14, 2026 13:05
284359c to
90a513aCompareCo-authored-by: GPT-5 Codex <codex@openai.com>
MemberAuthor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Some tools need to ask the runner for env values without making those reads cache dependencies. The default should stay safe, but callers need an explicit opt-out for env reads that only affect diagnostics or optional behavior.
Scope
Add a
trackedflag to bothgetEnvandgetEnvsIPC requests and Rust/Node clients. The option defaults totrue;tracked: falsestill serves the env value or match set but filters that read out of the post-run cache fingerprint. IPC records keep the tracked flag monotonic so a later tracked read of the same name or pattern wins over an earlier untracked read.This PR is intentionally placed after the getEnvs fingerprint PR so the opt-out is implemented against both env APIs at once.
Verification
cargo check -p vite_taskcargo test -p vite_task_server --test integrationcargo test -p vite_task_bin --test e2e_snapshots fetch_env_untracked_does_not_invalidate -- --ignoredcargo test -p vite_task_bin --test e2e_snapshots fetch_envs_untracked_does_not_invalidate -- --ignoredcargo clippy --locked --all-targets --all-features -- -D warnings