sync, 2020-11-21 - #136
Merged
Merged
Conversation
C++ & Python flavored read_wpt speedups
* Refactor checks for root & list name uniqueness and Route/ConnectedRoute correspondence for improved efficiency & error reporting and more concise code (#316) * Perform fewer case conversions on AltLabels & AltRouteNames for increased speed Processing traveler list files (#319) * C++: clean up a couple classes' static member definitions
* Retrieve elements by value rather than reference. Same principle as in #270, just without the big speed increase. Best practice nonetheless. * Convert traditional for loops to range for loops where possible, for cleaner more concise code.
refactor roots & list names; smash case
* C++: bugfix for duplicate AltLabels datacheck * closes#325 * hash tables for waypoint labels * closes#278 * C++: parallelism processing .list files * closes#274 * improved userlog error messages * closes#326 * closes#275 * listnamesinuse.log & unusedaltroutenames.log * closes#230 * preparation for #58 * #308 * [Route::store_traveled_segments](#58 (comment)) * C++: refactor chopped route (4-field) list line parsing into its own file
.list processing enhancements
* write UTF-8 byte order mark to split-region .list files if present * write .list lines triggering "duplicate label" or "Equivalent waypoint labels mark zero distance traveled in line: " user log messages to split-region .list files
2 region-splitting bugfixes
trim whitespace from datacheckfps.csv lines
Multi-region list file entries
LABEL_INVALID_CHAR fix
* 6-field .list entries cope with reversed point order within routes http://forum.travelmapping.net/index.php?topic=3648.msg19036#msg19036http://forum.travelmapping.net/index.php?topic=3652.msg19105#msg19105 * Implement DISCONNECTED_ROUTE datacheck http://forum.travelmapping.net/index.php?topic=3652
* add to list of all error codes with description of add'l info * add to datacheck_always _error
ConnectedRoute checks & fixes
Closes#252 * Require at least 1 numeral * Account for [NEWS] suffixes, as in I-35E & I-35W * Case insensitive Bus * Don't require full match; flag cases such as I-95Bus(42) and I-95Bus_N * Python & C++ flavors now behave identically * Only flag errors in the USA
BUS_WITH_I datacheck improvements
* Python: prevent crash when entire label is asterisks * C++: flag error when label == "*"
invalid char datacheck improvements
...not just visible ones
LABEL_INVALID_CHAR for all points
LACKS_GENERIC, DUPLICATE_LABEL, BUS_WITH_I
We've already checked for this condition in the outer if statement just above.
remove extraneous condition
and Waypoint datacheck reorganization per #349
INTERSTATE_NO_HYPHEN
prevent empty routes from crashing DISCONNECTED_ROUTE datacheck
to eliminate redundant string comparisons
US_LETTER datacheck
con_total_miles cleanup / C++ nmp_merged progress indication
to account for city abbrevs
expand US_LETTER datacheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.