Uh oh!
There was an error while loading. Please reload this page.
v0.15.0 - #1814
Merged
Merged
Conversation
…ed (#1694) Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
Co-authored-by: Julian Ventura <julian.ventura@lambdaclass.com>
Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com> Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: PatStiles <pdstiles78@gmail.com> Co-authored-by: avilagaston9 <gavila@fi.uba.ar>
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com> Co-authored-by: Marcos Nicolau <76252340+MarcosNicolau@users.noreply.github.com> Co-authored-by: PatStiles <33334338+PatStiles@users.noreply.github.com> Co-authored-by: Avila Gastón <72628438+avilagaston9@users.noreply.github.com> Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com> Co-authored-by: nicolau <marcosnicolau2003@gmail.com>
Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com> Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com> Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com> Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
… not been spent (#1725) Co-authored-by: Uriel Mihura <43704209+uri-99@users.noreply.github.com>
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com>
Co-authored-by: Tomás Casagrande <53660242+samoht9277@users.noreply.github.com> Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
…fixes_testnet_17_01 # Conflicts: # explorer/.env.dev # explorer/.env.example # explorer/lib/explorer_web/live/utils.ex # explorer/start.sh
Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com> Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
…li commands (#1553) Co-authored-by: Marcos Nicolau <marcosnicolau@lambdaclass.com> Co-authored-by: Urix <43704209+uri-99@users.noreply.github.com> Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
# Conflicts: # alerts/sender_with_alert.sh # explorer/.env.dev # explorer/.env.example
Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: Mario Rugiero <mrugiero@gmail.com> Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com>
…erServiceManager.sol (#1762) Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: Klaus Lungwitz <klaus.lungwitz@lambdaclass.com> Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
…e.sol (#1772) Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com>
…1770) Co-authored-by: MauroFab <maurotoscano2@gmail.com>
Changes to gas cost
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: JuArce <52429267+JuArce@users.noreply.github.com>
Co-authored-by: Mauro Toscano <12560266+MauroToscano@users.noreply.github.com> Co-authored-by: MauroFab <maurotoscano2@gmail.com>
# Conflicts: # batcher/aligned-sdk/src/core/types.rs # batcher/aligned-sdk/src/sdk.rs # batcher/aligned/src/main.rs
MauroToscano
marked this pull request as ready for review
March 27, 2025 14:36
There was a problem hiding this comment.
Pull Request Overview
This PR (v0.15.0) introduces several improvements and refactorings across the SDK and batcher modules. Key changes include:
- Changes to fee estimation logic and renaming of related functions and types.
- Refactoring network handling to use methods on the Network enum rather than passing explicit URLs.
- Enhancements to error messages and new metrics for queue tracking in the batcher.
Reviewed Changes
Copilot reviewed 188 out of 195 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| batcher/aligned-task-sender/README.md | Updated the CLI usage example to reflect the new network parameter instead of a hardcoded URL. |
| batcher/aligned-sdk/src/sdk.rs | Refactored fee estimation functions and updated documentation with new fee estimation types. |
| batcher/aligned-sdk/src/core/types.rs | Renamed PriceEstimate to FeeEstimationType and added a Custom option in the Network API. |
| batcher/aligned-sdk/src/core/errors.rs | Replaced MaxFeeEstimateError with FeeEstimateError across the SDK to reflect the new logic. |
| batcher/aligned-sdk/src/core/constants.rs | Updated fee estimation constants and added network address constants for the batcher. |
| batcher/aligned-sdk/src/communication/messaging.rs | Enriched error messages to include additional context on transaction fund handling. |
| batcher/aligned-sdk/src/communication/batch.rs | Small refactor to pass a cloned network in the proof verification loop. |
| batcher/aligned-batcher/src/sp1/mod.rs | Updated initialization of sp1-sdk components to use environment-based configuration. |
| batcher/aligned-batcher/src/metrics.rs | Added new metrics for tracking the queue length and queue size (bytes). |
| batcher/aligned-batcher/src/main.rs | Added a new CLI argument for address configuration and updated variable naming accordingly. |
| batcher/aligned-batcher/src/lib.rs | Integrated queue metric updates at critical points in the batch processing logic. |
| batcher/aligned-batcher/Cargo.toml | Upgraded sp1-sdk dependency to the latest version. |
| .github/workflows/build-and-test-go.yml | Removed outdated build steps and adjusted workflow steps to match the current project structure. |
Files not reviewed (7)
- .github/workflows/test-risc-zero-old.yml: Language not supported
- .github/workflows/test-sp1-old.yml: Language not supported
- Makefile: Language not supported
- alerts/.env.devnet: Language not supported
- alerts/.env.example: Language not supported
- alerts/sender_with_alert.sh: Language not supported
- batcher/aligned-batcher/rust-toolchain: Language not supported
Comments suppressed due to low confidence (1)
batcher/aligned-batcher/src/main.rs:27
- [nitpick] The CLI parameter is named 'addr' while later in the code it is reformatted as 'address'. Consider renaming 'addr' to 'address' in the CLI definition for consistent naming.
#[arg(short, long)]
Uh oh!
There was an error while loading. Please reload this page.
MarcosNicolau
approved these changes
Mar 27, 2025
Co-authored-by: Julian Arce <52429267+JuArce@users.noreply.github.com>
JuArce
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.15.0
Description