Uh oh!
There was an error while loading. Please reload this page.
fix: gate Unix-only test helpers on Windows - #94
Merged
Conversation
ORESoftware
marked this pull request as ready for review
August 4, 2026 04:12
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The exact Ubuntu/macOS/Windows static-mise certification found existing portability defects in test-only Unix fixtures. All 10 static environment unit tests and all 4 real
mise_environment_clitests passed on Windows, butcargo clippy --all-targets -- -D warningsthen exposed:tests/develop_shell_edge_cases.rscompiled as unused/dead code on Windows.tests/e2e.rsimported Unix permission APIs or depended on/bin/shwithout a target guard.Fix
Apply matching
#[cfg(unix)]boundaries only to test code that already requires Unix behavior:BTreeMap,OsStr/OsString,assert_success, andstdoutindevelop_shell_edge_cases;e2e.No production code or runtime behavior changes:
Validation completed
A native
windows-2025materialization run passed:cargo fmt --all --check;git diff --check;cargo test --locked --test develop_shell_edge_cases;cargo test --locked --test e2e --no-run; andcargo clippy --locked --all-targets -- -D warnings.The temporary materializer has been removed. The PR now contains exactly two ordinary test files with nine additive
#[cfg(unix)]attributes. Normal repository CI, development-shell, OCI, policy, hardening, formal review, and polyglot workflows are rerunning on the cleaned exact headf6fa80f3866754c6a36089bb3b44d62ebee636b9.Dependency chain
Found by: zed-pkg-test/zed-pkg-e2e#7
Static CLI candidate: #91
Linear: DEN-1439, DEN-1449