Uh oh!
There was an error while loading. Please reload this page.
Add feeling lucky, recently played, active discussions explore sections - #12498
Merged
Conversation
|
dylanjeffers
approved these changes
Jul 10, 2025
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
a few changes, make sure you review your work more
| const sdk = await audiusSdk() | ||
| const { data = [], related = {} } = | ||
| await sdk.full.explore.getFullRecentlyPlayed({ | ||
| userId: currentUserId ? Id.parse(currentUserId) : undefined |
Contributor
There was a problem hiding this comment.
lets check currentUserId and return early since this looks required?
| userTrackMetadataFromSDK | ||
| ) | ||
| primeTrackData({ |
Contributor
There was a problem hiding this comment.
use "primeRelatedData" to cover tracks and playlists, look at useTrackComments for an example
| tracks, | ||
| queryClient | ||
| }) | ||
| return data.map((item) => HashId.parse(item.id)) |
Contributor
There was a problem hiding this comment.
just return tracks.map( ... id) and you dont need to parse
| queryFn: async () => { | ||
| const sdk = await audiusSdk() | ||
| const { data = [] } = await sdk.full.tracks.getFeelingLuckyTracks({ | ||
| userId: currentUserId ? Id.parse(currentUserId) : undefined, |
Contributor
There was a problem hiding this comment.
does feeling lucky require logged in user? if not use OptionalId, check out other hooks for examples
| const sdk = await audiusSdk() | ||
| const { data = [] } = await sdk.full.tracks.getRecentPremiumTracks({ | ||
| userId: currentUserId ? Id.parse(currentUserId) : undefined | ||
| userId: currentUserId ? Id.parse(currentUserId) : undefined, |
| uid: UID | ||
| id: ID | ||
| source: PlaybackSource | ||
| }): void { |
| AsyncStorage.setItem(FEATURE_FLAG_ASYNC_STORAGE_SESSION_KEY, id.toString()), | ||
| setLogLevel: () => optimizely.setLogLevel('warn'), | ||
| environment: Config.ENVIRONMENT as Environment | ||
| environment: 'staging' // Config.ENVIRONMENT as Environment |
| import { env as envStage } from './env.stage' | ||
| const environment = Config.ENVIRONMENT | ||
| const environment = 'staging' // Config.ENVIRONMENT |
| const { data: exploreContent } = useExploreContent() | ||
| const { data: recommendedTracks } = useRecommendedTracks() | ||
| const { data: recentlyPlayed } = useRecentlyPlayedTracks() |
Contributor
There was a problem hiding this comment.
im a bit scared having all these hooks in this page cause they will all f ire at the same time. the idea with the progressive loading on mobile was to not lead to too much churn. but all good for now, lets see how this page performs
| size={TrackTileSize.LARGE} | ||
| statSize={'small'} | ||
| ordered={false} | ||
| togglePlay={function (uid: UID, id: ID): void { |
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9412812 | Triggered | Generic Password | b17e82c | packages/discovery-provider/ddl/local-test-replicas.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
isaacsolo pushed a commit
that referenced
this pull request
Jul 17, 2025
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo [5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo [b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ [cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers [308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell [3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed [0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed [179b457] Update eth rpc urls (#12552) KJ [bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson [1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis [a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers [e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers [3dcf5d3] Fix styling for chat message unfurls (#12550) KJ [b343ac0] Add asset detail pages (#12430) Farid Salau [5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau [4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers [013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ [69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed [cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis [bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed [2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson [cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers [99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo [6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ [ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers [3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ [a018dd1] Mobile web search explore fixes (#12534) Isaac Solo [b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis [72c05be] Mobile web top right menu (#12521) Reed [6c45c92] [PE-6515] Border for hex token icons (#12526) Reed [2a762b4] Clicking on token badges shows hover card too (#12527) Reed [d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers [fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson [e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers [81b1709] Fix incorrect comment display (#12529) KJ [d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers [0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers [df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo [923f09a] useTokenBalance with fake amounts (#12525) Reed [28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some more explore sections. Of note, feeling lucky is slightly different in that it's a single track and needs to refetch.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested on web and iOS sim against stage