Uh oh!
There was an error while loading. Please reload this page.
Aggregate AUDIO amount for X shares - #12530
Conversation
|
| `Thanks ${senderHandle} for the ${formatNumberCommas(amount)} ${ | ||
| ) => { | ||
| const totalValue = | ||
| price && amount ? Number(AUDIO(price).toString()) * amount : null |
There was a problem hiding this comment.
there could be a weird bug here if price or amount is 0... that's kind of undefined behavior anyway, but just figured i'd call out.
There was a problem hiding this comment.
I would expect price to be in dollars, not AUDIO?
| price?: string | ||
| ) => | ||
| `I just ${ | ||
| ) => { |
There was a problem hiding this comment.
i think this would be safer /better
const totalValue = AUDIO(AUDIO(price).value * BigInt(uiAmount))
totalValue.toLocaleString('en-US', { maximumFractionDigits: 2 })
There was a problem hiding this comment.
+1, do the math with BigInts to avoid precision errors
There was a problem hiding this comment.
yeah re marcus' comments on AUDIO vs. dollars... im a bit confused by the current impl haha
There was a problem hiding this comment.
sounds great, thanks gang
rickyrombo
left a comment
There was a problem hiding this comment.
I don't have context here but it's weird to me that price is being sent to AUDIO, as I would have expected it to be USD
| `Thanks ${senderHandle} for the ${formatNumberCommas(amount)} ${ | ||
| ) => { | ||
| const totalValue = | ||
| price && amount ? Number(AUDIO(price).toString()) * amount : null |
There was a problem hiding this comment.
I would expect price to be in dollars, not AUDIO?
| price?: string | ||
| ) => | ||
| `I just ${ | ||
| ) => { |
There was a problem hiding this comment.
+1, do the math with BigInts to avoid precision errors
There was a problem hiding this comment.
Bug: Tip Calculation Errors with Floating Point
The calculation of tip dollar values for share text now uses Number(price) * amount (or uiAmount) instead of the previously used fixed-decimal library. This introduces floating-point precision errors, leading to inaccurate dollar amounts. Furthermore, if price is an invalid string, Number(price) returns NaN, causing (~$NaN) to appear in the share text. BigInt arithmetic was suggested in PR discussions to prevent these precision issues.
packages/web/src/components/notification/Notification/TipReceivedNotification.tsx#L41-L44
packages/web/src/components/notification/Notification/TipSentNotification.tsx#L30-L32
packages/web/src/components/tipping/tip-audio/TipSent.tsx#L24-L25
packages/mobile/src/screens/notifications-screen/Notifications/TipReceivedNotification.tsx#L53-L54
packages/mobile/src/screens/notifications-screen/Notifications/TipSentNotification.tsx#L37-L38
packages/mobile/src/screens/tip-artist-screen/TipSentScreen.tsx#L36-L37
Bug: Invalid Price Handling in Share Text
The xShare function in various components incorrectly calculates the total value for share text. If the price parameter is an invalid number string, Number(price) returns NaN, causing totalValue to become NaN. The current price && amount (or uiAmount) check only verifies truthiness, not numeric validity, which results in (~$NaN) being displayed in the share text.
packages/mobile/src/screens/notifications-screen/Notifications/TipReceivedNotification.tsx#L53-L57
packages/mobile/src/screens/notifications-screen/Notifications/TipSentNotification.tsx#L37-L41
packages/web/src/components/notification/Notification/TipSentNotification.tsx#L30-L32
packages/mobile/src/screens/tip-artist-screen/TipSentScreen.tsx#L36-L38
packages/web/src/components/tipping/tip-audio/TipSent.tsx#L24-L26
BugBot free trial expires on July 22, 2025
Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo [5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo [b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ [cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers [308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell [3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed [0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed [179b457] Update eth rpc urls (#12552) KJ [bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson [1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis [a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers [e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers [3dcf5d3] Fix styling for chat message unfurls (#12550) KJ [b343ac0] Add asset detail pages (#12430) Farid Salau [5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau [4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers [013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ [69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed [cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis [bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed [2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson [cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers [99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo [6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ [ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers [3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ [a018dd1] Mobile web search explore fixes (#12534) Isaac Solo [b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis [72c05be] Mobile web top right menu (#12521) Reed [6c45c92] [PE-6515] Border for hex token icons (#12526) Reed [2a762b4] Clicking on token badges shows hover card too (#12527) Reed [d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers [fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson [e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers [81b1709] Fix incorrect comment display (#12529) KJ [d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers [0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers [df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo [923f09a] useTokenBalance with fake amounts (#12525) Reed [28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Description
Fixes all share-text to use the aggregate USDC price of token amount + token price