[PE-6537] Add comment_id to notification action data - #12548

Merged
dylanjeffers merged 2 commits into
mainfrom
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged

[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom
pe-6537-add-comment-id-to-notifs

Conversation

@dylanjeffers

@dylanjeffersdylanjeffers commented Jul 17, 2025

Copy link
Copy Markdown
Contributor

Description

Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links

@changeset-bot

changeset-botBot commented Jul 17, 2025•
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 02e2281

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

cursor[bot]
cursorBot reviewed Jul 17, 2025
View reviewed changes

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID

The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.

packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755

https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755

Fix in Cursor • Fix in Web

Bug: Comment Reaction Test Fails Due to Missing User ID

The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.

packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136

https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136

Fix in Cursor • Fix in Web

Bug: Test Suite Skipped Due to `test.only`

The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.

packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101

https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101

packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171

https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171

Fix in Cursor • Fix in Web

BugBot free trial expires on July 22, 2025
Learn more in the Cursor dashboard.

Was this report helpful? Give feedback by reacting with 👍 or 👎

@dylanjeffers
dylanjeffers merged commit 4c09e50 into mainJul 17, 2025
3 of 5 checks passed
@dylanjeffers
dylanjeffers deleted the pe-6537-add-comment-id-to-notifs branch July 17, 2025 16:36
audius-infra pushed a commit that referenced this pull request Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit that referenced this pull request Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments
+1 more reviewer
@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[PE-6537] Add comment_id to notification action data - #12548
Merged
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Jul 17, 2025
Merged
[PE-6537] Add comment_id to notification action data#12548
dylanjeffers merged 2 commits into
mainfrom 
pe-6537-add-comment-id-to-notifs
Conversation
@dylanjeffers
@dylanjeffersdylanjeffers
commented
Jul 17, 2025

Copy link


Copy Markdown

Contributor
Description
Fixes issue where comment-id was missing in comment notifications, which is needed for proper deep links
@changeset-bot
changeset-botBot
commented
Jul 17, 2025•

edited

Loading

Copy link


Copy Markdown

⚠️ No Changeset found
Latest commit: 02e2281
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
cursor[bot]
cursorBot
reviewed
Jul 17, 2025
View reviewed changes
@cursorcursorBot
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: API Response Inconsistency Missing Comment ID
The extend_comment_reaction function is missing the comment_id field in its API response. This is inconsistent with extend_comment, extend_comment_thread, and extend_comment_mention functions, which are updated to include it. As a result, comment reaction notifications will lack the comment_id required for deep links, contradicting the PR's purpose.
packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/src/api/v1/utils/extend_notification.py#L736-L755
Fix in Cursor • Fix in Web
Bug: Comment Reaction Test Fails Due to Missing User ID
The test for comment reaction notifications incorrectly expects comment_user_id in the notification data. The backend's notification generation and processing logic (including the API model and extend_comment_reaction function) does not include or process this field, causing test failures or incorrect results.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L133-L136
Fix in Cursor • Fix in Web
Bug: Test Suite Skipped Due to `test.only`
The test.only flag was accidentally committed on two test cases (Process push notification for comment reaction on others track and Render a single email), causing other tests in the suite to be skipped during execution.
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L100-L101
packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
https://github.com/AudiusProject/audius-protocol/blob/cdbd4c748d927aaf900f3f5228c5d42b2eca67fb/packages/discovery-provider/plugins/notifications/src/__tests__/mappings/commentReaction.test.ts#L170-L171
Fix in Cursor • Fix in Web
BugBot free trial expires on July 22, 2025

Learn more in the Cursor dashboard.
Was this report helpful? Give feedback by reacting with 👍 or 👎
@dylanjeffers
dylanjeffers
merged commit 4c09e50
into
mainJul 17, 2025

3 of 5 checks passed

@dylanjeffers
dylanjeffers
deleted the

pe-6537-add-comment-id-to-notifs

branch
July 17, 2025 16:36
audius-infra pushed a commit
that referenced
this pull request
Jul 18, 2025
audius-infra
Audius Protocol v0.7.201
98e6c5e
[179b457] Update eth rpc urls (#12552) KJ
[33d6c1a] Create bonk artist coin account on stage (#12558) Reed
[c220118] Revert "feat: Add BONK token support to backend and SDK (#12489)" (#12553) Marcus Pasell
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
audius-infra pushed a commit
that referenced
this pull request
Jul 19, 2025
audius-infra
Audius Client (Web and Mobile) v1.5.144
4751ddd
[280d9db] Add track tile carousel skeleton and fix width (#12565) Isaac Solo
[5dd5f50] Search/explore mobile web pass (#12562) Isaac Solo
[b49cb22] [PE-6505] Update in-app notif navigation for comments to highlight comment (#12554) KJ
[cad4bfc] [PE-6509] Add web coin leaderboard modal (#12556) Dylan Jeffers
[308a773] Fix setting USDC payout wallet (#12563) Marcus Pasell
[3c174c1] [PE-6539] Fix artist coin badge showing when 0 balance (#12560) Reed
[0d0c089] [PE-6530] Conditionally show chat message artist coin header (#12559) Reed
[179b457] Update eth rpc urls (#12552) KJ
[bd3f3cf] Fix mobile image fallback logic (#12549) Ray Jacobson
[1a752dd] Speed up mobile app warm start by another ~75% (#12555) JD Francis
[a96174d] [QA-2220] Fix mobile user-links with badge-v2 (#12557) Dylan Jeffers
[e9c0c3d] Add msw for coin endpoints (#12551) Dylan Jeffers
[3dcf5d3] Fix styling for chat message unfurls (#12550) KJ
[b343ac0] Add asset detail pages (#12430) Farid Salau
[5d6c245] Add non-native conversion to buy/sell modal (#12536) Farid Salau
[4c09e50] [PE-6537] Add comment_id to notification action data (#12548) Dylan Jeffers
[013f7f5] [PE-6524] Add scroll to comment section on comment link (#12545) KJ
[69f3ca0] [PE-6519] Send artist coin holder blast UI (#12538) Reed
[cfd654e] Fix misc mobile tile layout issues (#12542) JD Francis
[bee3f90] [PE-6516] YourCoins supports BONK on web (#12528) Reed
[2e51d03] [QA-2218] Fix artist popover badge (#12543) Ray Jacobson
[cabbd73] [PE-2215] Adjust share button size (#12533) Dylan Jeffers
[99238c5] Add feature flag to search explore milestone and optimize search fetches (#12541) Isaac Solo
[6f3a511] [PE-6502, PE-6504] Add comment highlighting for mobile (#12540) KJ
[ba3fcd0] [QA-2212] Improve bottom bar haptics (#12535) Dylan Jeffers
[3f1758e] [QA-2223] Fix ActionDrawer text color in dark mode (#12537) KJ
[a018dd1] Mobile web search explore fixes (#12534) Isaac Solo
[b3474b2] Improve mobile app refocus rerenders (#12532) JD Francis
[72c05be] Mobile web top right menu (#12521) Reed
[6c45c92] [PE-6515] Border for hex token icons (#12526) Reed
[2a762b4] Clicking on token badges shows hover card too (#12527) Reed
[d07fbb0] [PE-6420] Improve useCurrentAccount local-storage perf (#12524) Dylan Jeffers
[fd8574f] Add examples to @packages/fixed-decimal (#12531) Ray Jacobson
[e34f4bf] Aggregate AUDIO amount for X shares (#12530) Dylan Jeffers
[81b1709] Fix incorrect comment display (#12529) KJ
[d74a7bf] Fix TOKEN_ACCOUNT_NOT_FOUND events (#12523) Dylan Jeffers
[0467b88] [PE-6500] Add timezone to remix contest details (#12515) Dylan Jeffers
[df4e489] Add feeling lucky, recently played, active discussions explore sections (#12498) Isaac Solo
[923f09a] useTokenBalance with fake amounts (#12525) Reed
[28adbeb] feat: Add comprehensive BONK token support with multi-token swap func… (#12502) Farid Salau
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@cursorcursor[bot]cursor[bot] left review comments

+1 more reviewer

@Kyle-ShanksKyle-ShanksKyle-Shanks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

size/L

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@dylanjeffers@Kyle-Shanks